Skip to content

Fixes issues for https://github.com/Seungwoo321/vue-pivottable/issues/21 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Seungwoo321 merged 10 commits into from
Mar 8, 2022
Merged

Fixes issues for https://github.com/Seungwoo321/vue-pivottable/issues/21 #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
64280ea
Update DraggableAttribute.js
cbbdev Feb 17, 2022
21d69c5
Update Pivottable.js
cbbdev Feb 17, 2022
5535959
Update PivottableUi.js
cbbdev Feb 17, 2022
aea5838
Update PlotlyRenderer.js
cbbdev Feb 17, 2022
0e0da06
Update TableRenderer.js
cbbdev Feb 17, 2022
ab0016d
Update DraggableAttribute.js
cbbdev Feb 18, 2022
141c953
Update index.js
cbbdev Feb 18, 2022
44b0e34
Update Pivottable.js
cbbdev Feb 18, 2022
a3b5f92
Update PivottableUi.js
cbbdev Feb 18, 2022
bdce789
Update PlotlyRenderer.js
cbbdev Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions src/DraggableAttribute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,7 @@ export default {
const valueFilter = values.reduce((r, v) => {
r[v] = true
return r
}, {
...this.valueFilter
})
}, Object.assign({},this.valueFilter))
this.$emit('update:filter', { attribute, valueFilter })
},
removeValuesFromFilter (attribute, values) {
Expand All @@ -89,9 +87,7 @@ export default {
delete r[v]
}
return r
}, {
...this.valueFilter
})
}, Object.assign({},this.valueFilter))
this.$emit('update:filter', { attribute, valueFilter })
},
moveFilterBoxToTop (attribute) {
Expand Down Expand Up @@ -183,8 +179,7 @@ export default {
showMenu && h('div', {
staticClass: ['pvtCheckContainer']
},
[
...shown.map(x => {
shown.map(x => {
const checked = !(x in this.valueFilter)
return h('p', {
class: {
Expand Down Expand Up @@ -218,8 +213,8 @@ export default {
})
])
})
])
])
)
]);
},
toggleFilterBox (event) {
event.stopPropagation()
Expand Down
26 changes: 13 additions & 13 deletions src/Pivottable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
import TableRenderer from './TableRenderer'
import defaultProps from './helper/common'
import TableRenderer from './TableRenderer';
import defaultProps from './helper/common';
export default {
name: 'vue-pivottable',
mixins: [
defaultProps
],
computed: {
rendererItems () {
return this.renderers || Object.assign({}, TableRenderer)
return this.renderers || Object.assign({}, TableRenderer);
}
},
methods: {
createPivottable (h) {
const props = this.$props
const props = this.$props;
return h(this.rendererItems[this.rendererName], {
props: {
...props,
localeStrings: props.locales[props.locale].localeStrings
}
})
props: Object.assign(
props,
{localeStrings: props.locales[props.locale].localeStrings}
)
});
},
createWrapperContainer (h) {
return h('div', {
Expand All @@ -30,13 +30,13 @@ export default {
}
}, [
this.createPivottable(h)
])
]);
}
},
render (h) {
return this.createWrapperContainer(h)
return this.createWrapperContainer(h);
},
renderError (h, error) {
return this.renderError(h)
return this.renderError(h);
}
}
};
Loading