Skip to content
This repository was archived by the owner on Dec 17, 2024. It is now read-only.

Reformat to new standards#2

Merged
TroyKomodo merged 23 commits into
anatole/initfrom
troy/update
May 12, 2022
Merged

Reformat to new standards#2
TroyKomodo merged 23 commits into
anatole/initfrom
troy/update

Conversation

@TroyKomodo
Copy link
Copy Markdown
Contributor

@TroyKomodo TroyKomodo commented May 11, 2022

  • Health checks
  • generalize loaders between both v2 and v3
  • Metrics
  • Add k8s
  • add unit tests (will likely move to another pr since this might block indefinitely)
  • go through logic tree to make sure everything is okay.
  • mock redis + mongo instance

Copy link
Copy Markdown
Contributor

@AnatoleAM AnatoleAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting panics on all requests in my testing environment
(appears to come from the auth middleware)
{"level":"error","ts":1652312518.28433,"caller":"gql/gql.go:64","msg":"panic in request handler","panic":"runtime error: invalid memory address or nil pointer dereference","status":200,"duration":0,"method":"POST","path":"/v3","ip":"","origin":"","stacktrace":"github.com/seventv/api/internal/gql.New.func2.1\n\t/home/anatole/Projects/API/internal/gql/gql.go:64\nruntime.gopanic\n\t/usr/local/go/src/runtime/panic.go:838\nruntime.panicmem\n\t/usr/local/go/src/runtime/panic.go:220\nruntime.sigpanic\n\t/usr/local/go/src/runtime/signal_unix.go:818\ngithub.com/SevenTV/Common/structures/v3/query.(*Query).lock\n\t/home/anatole/Projects/Common/structures/v3/query/query.go:38\ngithub.com/SevenTV/Common/structures/v3/query.(*Query).Bans\n\t/home/anatole/Projects/Common/structures/v3/query/query.ban.go:18\ngithub.com/SevenTV/Common/structures/v3/query.(*Query).Users\n\t/home/anatole/Projects/Common/structures/v3/query/query.users.go:18\ngithub.com/seventv/api/internal/middleware.DoAuth\n\t/home/anatole/Projects/API/internal/middleware/auth.go:59\ngithub.com/seventv/api/internal/middleware.Auth.func1\n\t/home/anatole/Projects/API/internal/middleware/auth.go:32\ngithub.com/seventv/api/internal/gql.New.func1\n\t/home/anatole/Projects/API/internal/gql/gql.go:33\ngithub.com/fasthttp/router.(*Router).Handler\n\t/home/anatole/go/pkg/mod/github.com/fasthttp/router@v1.4.9/router.go:414\ngithub.com/seventv/api/internal/gql.New.func2\n\t/home/anatole/Projects/API/internal/gql/gql.go:96\ngithub.com/valyala/fasthttp.(*Server).serveConn\n\t/home/anatole/go/pkg/mod/github.com/valyala/fasthttp@v1.36.0/server.go:2338\ngithub.com/valyala/fasthttp.(*workerPool).workerFunc\n\t/home/anatole/go/pkg/mod/github.com/valyala/fasthttp@v1.36.0/workerpool.go:224\ngithub.com/valyala/fasthttp.(*workerPool).getCh.func1\n\t/home/anatole/go/pkg/mod/github.com/valyala/fasthttp@v1.36.0/workerpool.go:196"}

Fixed at ada3f50

Comment thread cmd/main.go
Comment thread internal/gql/gql.go
Comment thread internal/rest/rest.go
Comment thread cmd/main.go Outdated
Comment thread cmd/main.go Outdated
@TroyKomodo TroyKomodo merged commit 47519af into anatole/init May 12, 2022
@TroyKomodo TroyKomodo deleted the troy/update branch May 12, 2022 15:54
AnatoleAM added a commit that referenced this pull request May 17, 2022
* Add base + GQL

* Fix lint

* prettier - ignore generated docs

* Update common

* Add REST

* GQL v2 emulation

* Reformat to new standards (#2)

* basedcigar

* remove go work

* add ignore on go.work

* fix prettier

* run my tests

* minor refactor

* global loaders

* add heath tests

* add make work

* clean -> node_modules

* remove .gitignore

* rename header

* add redis + mongo init

* make dev

* make dev

* Update config example

* Non-fatal rmq/s3 instantiation

* Add query, mutate instances to global context

* Fix lint

* Reinstate websocket

* Reinstate nil-fill in loaders

* More loader fixes

* update deps

Co-authored-by: Anatole <me@anatole.dev>

* test

* GQL - add `createCosmeticPaint` mutation

* Fix linter versions

Co-authored-by: Troy <49777269+TroyKomodo@users.noreply.github.com>
Co-authored-by: TroyKomodo <troybensonsa@gmail.com>
kars0nn pushed a commit to kars0nn/API that referenced this pull request Dec 21, 2022
# This is the 1st commit message:

k8s: update chatterino version

# This is the commit message SevenTV#2:

Changed look of website a lil bit, now responsive

# This is the commit message SevenTV#3:

Changed look of website a lil bit, now responsive

# This is the commit message SevenTV#4:

Entitlement & Cosmetic Events (SevenTV#140)

* upgrade dependencies

* rest/v3(presence.write): check source validity

* fully remove websocket implementation

* multi-condition dispatch, entitl./cosmetic events

* refactor: gql modelize helpers to new package

* Presence cosmetic fanout

* Event dispatch dedupe hash

* update common
# This is the commit message SevenTV#5:

events/payload: update hello, ack, heartbeat

# This is the commit message SevenTV#6:

formatted and removed unused imports from me

# This is the commit message SevenTV#7:

Put route-item and side bar into components
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants