This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Fix Event Names#2
Merged
Merged
Conversation
Contributor
|
Wtf is this? |
Contributor
|
The default listeners are not. Open and message, those are both client side afaik. Open is when the connection is opened and message is all messages. |
Contributor
|
Why are you changing the payload structure? |
Contributor
Author
I changed back |
Contributor
Author
So that it's in line with 7TV semantics. It was also missing emote data |
Contributor
|
What? Do u mean the update event? |
TroyKomodo
approved these changes
Aug 5, 2021
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default listeners outlined in the
EventSourceWeb API areopenandmessage. This changes the "update" event to "message". "connected" was also changed to "listening", as it sounds redundant with the default-firedopenevent, whereaslisteningindicates the connection is fully ready to receive events.