Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

Fix Event Names#2

Merged
TroyKomodo merged 12 commits into
devfrom
feat/fix-event-names
Aug 5, 2021
Merged

Fix Event Names#2
TroyKomodo merged 12 commits into
devfrom
feat/fix-event-names

Conversation

@AnatoleAM
Copy link
Copy Markdown
Contributor

@AnatoleAM AnatoleAM commented Aug 5, 2021

The default listeners outlined in the EventSource Web API are open and message. This changes the "update" event to "message". "connected" was also changed to "listening", as it sounds redundant with the default-fired open event, whereas listening indicates the connection is fully ready to receive events.

@AnatoleAM AnatoleAM requested a review from TroyKomodo August 5, 2021 03:45
@AnatoleAM AnatoleAM self-assigned this Aug 5, 2021
@TroyKomodo
Copy link
Copy Markdown
Contributor

Wtf is this?

@TroyKomodo
Copy link
Copy Markdown
Contributor

The default listeners are not. Open and message, those are both client side afaik. Open is when the connection is opened and message is all messages.

@TroyKomodo
Copy link
Copy Markdown
Contributor

Why are you changing the payload structure?

@AnatoleAM
Copy link
Copy Markdown
Contributor Author

The default listeners are not. Open and message, those are both client side afaik. Open is when the connection is opened and message is all messages.

I changed back open (now listening) after discovering the browser fires it autonomously. Also, since the URL itself indicates the type of data the client expects, there's no need to specify it

@AnatoleAM
Copy link
Copy Markdown
Contributor Author

Why are you changing the payload structure?

So that it's in line with 7TV semantics. It was also missing emote data

@TroyKomodo
Copy link
Copy Markdown
Contributor

What? Do u mean the update event?

@TroyKomodo
Copy link
Copy Markdown
Contributor

👍

@TroyKomodo TroyKomodo merged commit 7dd0b4b into dev Aug 5, 2021
@TroyKomodo TroyKomodo deleted the feat/fix-event-names branch August 5, 2021 10:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants