Skip to content

fix(twitch): badges not displayed#1006

Merged
TroyKomodo merged 5 commits into
SevenTV:feat/bug-fixesfrom
pimothyxd:fix/badges-not-displayed
Mar 4, 2024
Merged

fix(twitch): badges not displayed#1006
TroyKomodo merged 5 commits into
SevenTV:feat/bug-fixesfrom
pimothyxd:fix/badges-not-displayed

Conversation

@pimothyxd
Copy link
Copy Markdown
Contributor

@pimothyxd pimothyxd commented Feb 28, 2024

Proposed changes

Entering a chat sometimes caused badges to not show up (generally with historic messages). This was caused because the badge sets weren't exposed yet with the way they were extracted from it's component. The old implementation relies on a message to already be displayed, thus having no messages would cause the badge sets to not be assigned until a message is to be displayed.

This is however fixed by using the chat room component instead. It exposes the badge sets through it's props instead of it's children.

Types of changes

What types of changes does your code introduce to 7TV?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

See the following snippets:

before_badge_fix.png

should now look like:

after_badge_fix.png

@TroyKomodo TroyKomodo merged commit 8bf508a into SevenTV:feat/bug-fixes Mar 4, 2024
@pimothyxd pimothyxd deleted the fix/badges-not-displayed branch March 10, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants