Skip to content

refactor: general style improvements#1034

Merged
TroyKomodo merged 2 commits into
SevenTV:feat/bug-fixesfrom
pimothyxd:refactor/gen-style-improv
May 6, 2024
Merged

refactor: general style improvements#1034
TroyKomodo merged 2 commits into
SevenTV:feat/bug-fixesfrom
pimothyxd:refactor/gen-style-improv

Conversation

@pimothyxd
Copy link
Copy Markdown
Contributor

Proposed changes

See the images below.

Types of changes

What types of changes does your code introduce to 7TV?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Before:

Screen_Shot_2024-05-05_at_03 40 23_PM

After:

Screen_Shot_2024-05-05_at_03 55 48_PM

Before:

image

After:

Screen_Shot_2024-05-05_at_04 02 45_PM

@treejadey
Copy link
Copy Markdown
Contributor

there used to be the twitter card for 7tv on the right of the settings menu, did you remove it or is it broken?

@pimothyxd
Copy link
Copy Markdown
Contributor Author

there used to be the twitter card for 7tv on the right of the settings menu, did you remove it or is it broken?

As far as I know, it broke at one point and was then removed in 4c0f3b9 but the layout was never updated along with that change.

@TroyKomodo TroyKomodo merged commit b03651d into SevenTV:feat/bug-fixes May 6, 2024
@pimothyxd pimothyxd deleted the refactor/gen-style-improv branch May 6, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants