fix: displayName mentions#513
Closed
lukashoracek wants to merge 1 commit into
Closed
Conversation
lukashoracek
force-pushed
the
multi-lang-mentions
branch
3 times, most recently
from
c9ef64b to
90beaca
Compare
lukashoracek
force-pushed
the
multi-lang-mentions
branch
2 times, most recently
from
88eeea7 to
6b91a95
Compare
AnatoleAM
reviewed
Jun 28, 2023
Comment on lines
+470
to
+475
| // Workaround \b not working properly with unicode characters | ||
| const hasMultiLangName = "displayName" in identity && identity.username !== identity.displayName.toLowerCase(); | ||
| const rxs = hasMultiLangName | ||
| ? `((?<=^|\\P{L})${identity.username}|${identity.displayName}(?=\\P{L}|$))` | ||
| : `\\b${identity.username}\\b`; | ||
| const rx = new RegExp(rxs, hasMultiLangName ? "iu" : "i"); |
Contributor
There was a problem hiding this comment.
This seems a little overengineered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds/fixes support for mentions using the displayName rather than the user's international username
JavaScript RegExp does not support unicode
\bor(*UCP)so I had to use this ugly workaround, which is used only if the user has different display name than username. I am not sure if there is any better solution than this. Lookbehind support should be fine considering 7TV does not have a Safari extensionI also changed the mention regex to
@\S*otherwise unicode mentions are not matchedFixes #471