[Bug Fix] React button overlap in hidden elements feature#555
Closed
ZemyCode wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
@AnatoleAM I discovered this bug right after testing in the nightly version... should be a quick fix though. Is there a way to bypass the changelog check? Not really sure if a changelog update is necessary here. |
AnatoleAM
added
the
skip changelog check
ZemyCode
changed the title
AnatoleAM
reviewed
May 8, 2023
Comment on lines
+209
to
+217
| // Remove entire div containing live noti button to get rid of left padding | ||
| div[data-target="channel-header-right"] | ||
| > *:nth-child(2) | ||
| > *:nth-child(1) | ||
| > *:nth-child(2) | ||
| > *:nth-child(1) | ||
| > *:nth-child(2) { | ||
| display: none !important; | ||
| } |
Contributor
There was a problem hiding this comment.
This is likely to break, at this point it may be preferable to hook the react component itself rather than use purely CSS.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
Small bug fix if hiding "Unfollow" button without hiding "React" button.
This PR also adds another selector for removing the live notification button with the goal of removing the left padding to make the UI look cleaner after removal. However, the original selector is still added as a fallback option since the new selector relies on a chain of multiple children.
Screenshots
Normal:
Before Fix:
With just unfollow hidden:
With unfollow and live notification hidden:
With just live notification hidden:
After Fix:
With just unfollow hidden:
With unfollow and live notification hidden:
With just live notification hidden:
