pause chat while using mod slider#561
Conversation
| ); | ||
|
|
||
| const handleDown = (e: PointerEvent) => { | ||
| if (shouldPauseChat.value) scroller.pause(); |
There was a problem hiding this comment.
The nature of the pause should be retained so that the chat isn't unpaused by mod slider if it was already paused for a different reason. Check that scrolling wasn't already paused, then set a boolean ref to instruct whether to unpause later.
| data.calculate(0); | ||
| (e.target as HTMLElement).releasePointerCapture(e.pointerId); | ||
|
|
||
| if (shouldPauseChat.value) scroller.unpause(); |
There was a problem hiding this comment.
Check if the pause was triggered by the mod slider
|
the last commit pushed should resolve the concerns with checking if the chat was paused by the mod slider or not |
|
The issue with this change is that it risks creating conflicts in the future. Pausing chat must be extended, with something such as a reason field in order to avoid this. Closing because this has been up for a long time but you are free to re-integrate this alongside a better pause method. |
2 participants
Adds option to pause the chat scroll while using the mod slider