Fixed slow-mode timer on twitch#611
Closed
simensBat wants to merge 4 commits into
Closed
Conversation
Author
|
@AnatoleAM Сan you take a look here too please |
AnatoleAM
suggested changes
Jun 26, 2023
| defineFunctionHook(handler, "handleMessage", function (old, msg: Twitch.AnyMessage) { | ||
| const ok = onMessage(msg); | ||
| if (ok) return ""; // message was rendered by the extension | ||
| if (ok) return old?.call(this, msg); // message was rendered by the extension |
Contributor
There was a problem hiding this comment.
This is not a valid situation as it would lead to messages being rendered by native chat in the background, severely decreasing performance.
Contributor
|
If a more suitale solution is found open a new pull request. |
|
Hi, thanks for the fix but this issue is still appearing in latest 7TV version both nightly and stable releases, both on latest version of Chrome and Firefox with default configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #475.
There was a problem with the watcher in the component. src/site/twitch.tv/modules/chat/ChatList.vue
In a standard situation, we render messages in a chat using extensions, apparently at this moment the context is lost and the functionality with the work of the slow mod begins to break. The data before the display component simply does not come.
I tried explicitly returning
return old?.call(this, msg);instead ofreturn ""And this solved the problem of displaying the slow mode text.I looked at the work of the chat and did not find any failures in the messages.
As it was before:
screencast-newtab-2023.05.17-19_50_33.webm
How is it now:
screencast-newtab-2023.05.17-19_53_12.webm