Add setting to prevent Video quality drop#638
Conversation
| document.addEventListener( | ||
| "visibilitychange", | ||
| (e) => { | ||
| e.stopImmediatePropagation(); |
There was a problem hiding this comment.
This is not a good solution as it would prevent any other visibilitychange listeners from functioning. This includes one used by the Extension to pause chat in an out-of-focus state.
| } else { | ||
| try { | ||
| document.removeEventListener("visibilitychange", (e) => { | ||
| e.stopImmediatePropagation(); |
There was a problem hiding this comment.
This is not a good solution as it would prevent any other visibilitychange listeners from functioning. This includes one used by the Extension to pause chat in an out-of-focus state.
| { | ||
| id: "video", | ||
| kind: "config", | ||
| configEffect: ["general.hd-video.enabled"], | ||
| title: t("onboarding.config_question.video"), | ||
| }, |
There was a problem hiding this comment.
This is not an option relevant enough to be prompted during onboarding
| watchEffect(() => { | ||
| if (enableHDVideo.value) { | ||
| try { | ||
| document.addEventListener( |
There was a problem hiding this comment.
This listener is never removed.
| } | ||
| } else { | ||
| try { | ||
| document.removeEventListener("visibilitychange", (e) => { |
There was a problem hiding this comment.
This will not remove anything as it creates a new function with its own identity.
|
|
||
| <script lang="ts"> | ||
| export const config = [ | ||
| declareConfig("general.hd-video.enabled", "TOGGLE", { |
There was a problem hiding this comment.
nit: config key
| declareConfig("general.hd-video.enabled", "TOGGLE", { | |
| declareConfig("general.force_hd_video", "TOGGLE", { |
|
Closing as stale |
2 participants
implements #628. since there wasnt any feedback, i just went ahead and used the linked code.
no i18n yet