settings(feat): reset to default value#758
Merged
Merged
Conversation
Contributor
Author
|
I was thinking that another property ( |
Contributor
|
The behavior of this isn't quite right. Ideally it should remove the setting from the stored table entirely, so that if a setting's default value changes for some reason it's as if the user had never changed the setting. Allowing the post-reset state to be separate from the initial state adds to potential user confusion. |
AnatoleAM
suggested changes
Jul 22, 2023
AnatoleAM
approved these changes
Jul 22, 2023
Contributor
AnatoleAM
left a comment
There was a problem hiding this comment.
Thank you for the contribution 🙂
2f894fd to
056b5fe
Compare
2547techno
pushed a commit
to 2547techno/Extension
that referenced
this pull request
Jul 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds #576
taking suggestions on css formatting and handling custom components/ignores