Skip to content

settings(feat): reset to default value#758

Merged
AnatoleAM merged 5 commits into
SevenTV:masterfrom
chipsTM:feat/reset-default-settings
Jul 22, 2023
Merged

settings(feat): reset to default value#758
AnatoleAM merged 5 commits into
SevenTV:masterfrom
chipsTM:feat/reset-default-settings

Conversation

@chipsTM
Copy link
Copy Markdown
Contributor

@chipsTM chipsTM commented Jul 6, 2023

adds #576

image

taking suggestions on css formatting and handling custom components/ignores

@chipsTM
Copy link
Copy Markdown
Contributor Author

chipsTM commented Jul 6, 2023

I was thinking that another property (disableReset ?) should be added to SettingNode interface so that a setting can be declared as non-resettable when one uses declareConfig. At least this way we can exclude custom types or types with non-primitive values?

@Melonify
Copy link
Copy Markdown
Contributor

The behavior of this isn't quite right. Ideally it should remove the setting from the stored table entirely, so that if a setting's default value changes for some reason it's as if the user had never changed the setting.

Allowing the post-reset state to be separate from the initial state adds to potential user confusion.

Comment thread src/app/settings/SettingsNode.vue Outdated
Copy link
Copy Markdown
Contributor

@AnatoleAM AnatoleAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 🙂

@AnatoleAM AnatoleAM changed the title Reset to default setting feature settings(feat): reset to default value Jul 22, 2023
@AnatoleAM AnatoleAM force-pushed the feat/reset-default-settings branch from 2f894fd to 056b5fe Compare July 22, 2023 05:51
@AnatoleAM AnatoleAM enabled auto-merge (squash) July 22, 2023 05:51
@AnatoleAM AnatoleAM merged commit 7ff8bf4 into SevenTV:master Jul 22, 2023
2547techno pushed a commit to 2547techno/Extension that referenced this pull request Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants