Skip to content

#959 | Added option to hide channel point balance button#960

Merged
TroyKomodo merged 5 commits into
SevenTV:feat/bug-fixesfrom
goralight:feature/hide-channel-points-button
Feb 17, 2024
Merged

#959 | Added option to hide channel point balance button#960
TroyKomodo merged 5 commits into
SevenTV:feat/bug-fixesfrom
goralight:feature/hide-channel-points-button

Conversation

@goralight
Copy link
Copy Markdown
Contributor

#959 : Added an option to hide the channel point balance button, which is under the chat input.

Enabled:
image

Disabled:
image

Comment thread src/site/twitch.tv/modules/hidden-elements/HiddenElementsModule.vue
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 24, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ goralight
✅ TroyKomodo
❌ John


John seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@TroyKomodo TroyKomodo changed the base branch from master to feat/bug-fixes February 17, 2024 02:54
@TroyKomodo TroyKomodo merged commit 7934310 into SevenTV:feat/bug-fixes Feb 17, 2024
@goralight
Copy link
Copy Markdown
Contributor Author

goralight commented Feb 17, 2024

@TroyKomodo I've signed the CLA agreement under @goralight , the John name was when I didn't have my git config set up correctly and was using a wrong name / email. Are you able to remove the John check or just approve it now that @goralight has been signed?

@TroyKomodo
Copy link
Copy Markdown
Contributor

I can't change it because it would require to rebase the PR but it's fine. The cla typically is made prior to any changes going in but it was added long after this project started. The new rewrite of this extension will be more strict about signatures but we plan to get rid of this implementation soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants