Skip to content

fix: pad user's owned emotes section#631

Merged
AnatoleAM merged 1 commit into
SevenTV:devfrom
jupjohn:fix/owned-emotes-section-padding
Aug 28, 2022
Merged

fix: pad user's owned emotes section#631
AnatoleAM merged 1 commit into
SevenTV:devfrom
jupjohn:fix/owned-emotes-section-padding

Conversation

@jupjohn
Copy link
Copy Markdown
Contributor

@jupjohn jupjohn commented Aug 28, 2022

This PR aims to fix an issue where the padding of a user's "Owned emotes" section was inconsistent with the previous "Channel emotes" section. This appears to be caused by a difference in how the sections are laid out.

Current layout as of 54066ff (ignore Firefox's SS tool adding the navbar to the middle)
image


Off-topic: I thought this would be a simple "clone & commit" deal, but I have to say the developer experience of getting this solution running has been a bit painful. The reliance on font-awesome pro packages breaks both the install and dev serer. It would be great if either this dependency was removed or a CONTRIBUTING guide was added explaining how to set this up.

I was also unable to test this locally as it appears to need an auth server running locally? No documentation so have no idea how to test that.

Thanks @Nerixyz for sending me a patch just to get this working.

brings the section in line with the previous channel emotes section
@AnatoleAM
Copy link
Copy Markdown
Contributor

AnatoleAM commented Aug 28, 2022

The reliance on font-awesome pro packages breaks both the install and dev serer. It would be great if either this dependency was removed or a CONTRIBUTING guide was added explaining how to set this up.

There is work being done to add a wrapper around icons to make fontawesome an optional dependency and allow selecting different libraries to replace the paid one. Contributing docs are planned, but the priority is currently to ensure a good service for a majority of users, which has slightly delayed the planned improvements to the developer experience.


Thank you for the pull request.

@AnatoleAM AnatoleAM merged commit 598eaae into SevenTV:dev Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants