fix: pad user's owned emotes section#631
Merged
Merged
Conversation
brings the section in line with the previous channel emotes section
Contributor
There is work being done to add a wrapper around icons to make fontawesome an optional dependency and allow selecting different libraries to replace the paid one. Contributing docs are planned, but the priority is currently to ensure a good service for a majority of users, which has slightly delayed the planned improvements to the developer experience. Thank you for the pull request. |
AnatoleAM
approved these changes
Aug 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an issue where the padding of a user's "Owned emotes" section was inconsistent with the previous "Channel emotes" section. This appears to be caused by a difference in how the sections are laid out.
Current layout as of 54066ff (ignore Firefox's SS tool adding the navbar to the middle)

Off-topic: I thought this would be a simple "clone & commit" deal, but I have to say the developer experience of getting this solution running has been a bit painful. The reliance on font-awesome pro packages breaks both the install and dev serer. It would be great if either this dependency was removed or a
CONTRIBUTINGguide was added explaining how to set this up.I was also unable to test this locally as it appears to need an auth server running locally? No documentation so have no idea how to test that.
Thanks @Nerixyz for sending me a patch just to get this working.