Main nav accessibility improvements#703
Closed
acdvs wants to merge 2 commits into
Closed
Conversation
AnatoleAM
force-pushed
the
dev
branch
6 times, most recently
from
011df67 to
f17bf90
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the accessibility of the main nav.
The Tooltip component now passes its generated unique label for use by any child element that needs to attach it (e.g., for
aria-labelledby).Ideally, the entire header nav needs to be restructured to make better use of semantic HTML and to standardize button structure, but I didn't want to interfere with any styling for this PR.