Skip to content

Add description of custom cable required for daisy chain adapter#172

Merged
elsevers merged 4 commits into
next-releasefrom
feature/add-dca-cable-info
May 18, 2026
Merged

Add description of custom cable required for daisy chain adapter#172
elsevers merged 4 commits into
next-releasefrom
feature/add-dca-cable-info

Conversation

@elsevers
Copy link
Copy Markdown
Contributor

Closes #166

Notes

Self-Review

  1. Are all files under 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
  2. Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
  3. Do all Markdown files follow the CONTRIBUTING article template? N/A - this follows the docs.amdc.dev article template
  4. Do all links work in the material that the PR is adding? Yes
  5. Is the PR configured to close the correct issue(s)? Yes
  6. Did the PR fully address the Approach section of the issue(s) it is closing? Yes

Reviewer Instructions

Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.

Appendix

This section should be the same for all PRs. Do not edit this section when creating a PR.

Review Checklists

Checklists maintained by the eLev lab for research repositories include:

Standard checklist

1. Are all files under 300 kB (if not, please carefully assess whether it is worth committing them)? **Yes or No**
2. Are all files named according to the appropriate [naming convention](https://github.com/Severson-Group/research-repo-template?tab=readme-ov-file#file-naming), i.e., dash-case, camelCase, snake case? **Yes or No**
3. Do all Markdown files follow the [CONTRIBUTING article template](https://github.com/Severson-Group/.github/blob/main/CONTRIBUTING.md#markdown-documentation-template)? **Yes or No**
4. Do all links work in the material that the PR is adding? **Yes or No**
5. Is the PR configured to close the correct issue(s)? **Yes or No**
6. Did the PR fully address the `Approach` section of the issue(s) it is closing? **Yes or No**

Please work on addressing any **No** items.

@elsevers elsevers changed the base branch from main to next-release May 17, 2026 23:38
@elsevers elsevers requested a review from AwesomeTornado May 17, 2026 23:38
Copy link
Copy Markdown
Collaborator

@AwesomeTornado AwesomeTornado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elsevers The graphic you have attached does not render properly when using the dark mode theme for the website. I've approved this because it seems to be the standard, but it should really be changed.

Other than that, docs compile well, no warnings, page renders properly, markdown is formatted well.

  1. Are all files under 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
  2. Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
  3. Do all Markdown files follow the CONTRIBUTING article template? Yes
  4. Do all links work in the material that the PR is adding? Yes
  5. Is the PR configured to close the correct issue(s)? Yes
  6. Did the PR fully address the Approach section of the issue(s) it is closing? Yes

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Export SVG with white background if possible to allow for dark mode viewing.
I've attached a screenshot of what the graphic looks like on my device.

Image

@elsevers
Copy link
Copy Markdown
Contributor Author

Nice catch. I discovered that this theme let's us have separate graphics for light vs dark mode. Take a look at what I just pushed up on the branch and see what you think. We can deploy it to other graphics as well.

:width: 75%
:align: center
:class: only-light
:width: 75%
:align: center
:class: only-dark
image

@elsevers elsevers requested a review from AwesomeTornado May 18, 2026 00:29
@AwesomeTornado
Copy link
Copy Markdown
Collaborator

@elsevers It's looking better but not fully there yet. There is supposed to be text on top of the ovals, but it is invisible because it is black. Change the text color, highlight it with a light color, or place a light colored box behind it and it should be good to go.

@elsevers
Copy link
Copy Markdown
Contributor Author

Nice. Got it now.

image

Copy link
Copy Markdown
Collaborator

@AwesomeTornado AwesomeTornado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elsevers This looks amazing!

  1. Are all files under 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
  2. Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
  3. Do all Markdown files follow the CONTRIBUTING article template? Yes
  4. Do all links work in the material that the PR is adding? Yes
  5. Is the PR configured to close the correct issue(s)? Yes
  6. Did the PR fully address the Approach section of the issue(s) it is closing? Yes

@elsevers elsevers merged commit 1cffa04 into next-release May 18, 2026
@elsevers elsevers deleted the feature/add-dca-cable-info branch May 18, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AMDS docs: explain custom cabling needed to daisy chain two AMDS boards

2 participants