Add changelog notes for v1.3.0 release#361
Merged
Conversation
noguchi-takahiro
approved these changes
Apr 9, 2025
Contributor
noguchi-takahiro
left a comment
There was a problem hiding this comment.
Thank you @elsevers. This looks good.
Level 1 review summary:
- Does the code run without error and produce the expected result? N/A
- Does the code comply with the code guidelines? N/A
- Does the code documentation comply with the documentation guidelines? N/A
- Is the writing, grammar, and syntax correct and clear? Yes
- Is the changeset compliant with the eMach architecture? Yes
- Does this review consider whether this physics are accurate? N/A
- Are the correct issues being closed (and are there no partially completed issues)? N/A
- Did the reviewer change the release schedule for the issues bing closed? No
- Did the reviewer change the branch the PR is being merged into? No
- Is PR approved to Level 2? Yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.