feat(Networking): add websocket client/server support#307
Draft
ShadowApex wants to merge 1 commit intomainfrom
Draft
feat(Networking): add websocket client/server support#307ShadowApex wants to merge 1 commit intomainfrom
ShadowApex wants to merge 1 commit intomainfrom
Conversation
7812f70 to
b62dc7d
Compare
|
As a future and optional enhancement to this, what do you think about creating a secure channel protocol between the client/server? I don’t imagine ensuring confidentiality to be a requirement, but I think strong, mutual authentication would be great. The noise protocol framework as used by WireGuard makes this pretty straightforward to design and implement one. |
Contributor
|
Aside from a rebase, what is this waiting on? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds websocket source/target devices that use the UCIS standard for its wire protocol. To use this feature, you can now use the
websockettarget device which exposes anorg.shadowblip.Input.Websocketdbus interface that can be used to connect to a remote instance of InputPlumber to route input over the network to another device.To start a websocket server (i.e. a websocket source device), an entry can be added to a composite device config with the address/port to listen on:
Then using either the dbus interface, or the cli, you can connect remote composite device:
This change required some amount of refactoring to use a new device enum instead of our previous assumption that all source devices would be udev devices.