QOL: centralize normalize/denormalize functions in src/input/event/value.rs #487
Conversation
pastaq
left a comment
pastaq
left a comment
There was a problem hiding this comment.
I don't think we need the u8 casts. Aside from that it looks good.
blakesmittty
force-pushed
the
qol-normalize_values-465
branch
from
ff1db85 to
9275912
Compare
|
@blakesmittty One other thing I didn't catch before but would be a good change would be to reduce the number of commits. As this is a simple change just one commit should be sufficient. The commit title for your first commit is actually perfect for capturing the scope of work. If you wanted to add the amplifying information from the other commits for all the specific changes to each source and target implementation below the commit title, that would be okay, but it's not necessary. |
|
@pastaq thanks for the feedback, noted for the future👍 |
You should be able to squash the commits and force push the branch |
…put/event/value.rs
blakesmittty
force-pushed
the
qol-normalize_values-465
branch
from
9275912 to
2d4616c
Compare
|
@pastaq done 👍 |
ShadowApex
left a comment
ShadowApex
left a comment
There was a problem hiding this comment.
Looks great! Thank you for this!
|
🎉 This PR is included in version 0.71.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
3 participants
Fixes #465
This refactor moves the repeated implementations of the [de]normalize_[un]signed_value functions into 'src/input/event/value.rs' so they can be reused by the source and target implementations.
No functional changes.