Skip to content

fix(build): fix build/packages issue and update to comply with new c++ standards#365

Merged
dyanikoglu merged 2 commits intoShadowfallStudios:devfrom
CanisHelix:dev
Mar 5, 2022
Merged

fix(build): fix build/packages issue and update to comply with new c++ standards#365
dyanikoglu merged 2 commits intoShadowfallStudios:devfrom
CanisHelix:dev

Conversation

@CanisHelix
Copy link
Contributor

@CanisHelix CanisHelix commented Mar 3, 2022

Add Categories to BP Exposed Functions and Properties.

Include missing LocalPlayer include.

As per https://docs.unrealengine.com/5.0/en-US/MigrationGuide/ updating from Native Pointers to TObjectPtr's. Without this change, errors like Error: Native pointer usage in member declaration detected [[[AALSBaseCharacter*]]]. This is disallowed for the target/module, consider TObjectPtr as an alternative. will occur if compiled outside of a path containing /plugins/. So if a user migrates to their own project source folder, or once Epic fixes up the TODO in https://github.com/EpicGames/UnrealEngine/blob/5.0.0-preview-1/Engine/Source/Programs/UnrealHeaderTool/Private/HeaderParser.cpp#L4144-L4152 to remove the current exclusion, users will face compilation errors. This commit future proof's this.

Add Categories to BP Exposed Functions and Properties.
Include missing LocalPlayer include.
@CanisHelix CanisHelix changed the title fix(build): fix build/packages issue fix(build): fix build/packages issue and update to comply with new c++ standards Mar 4, 2022
@dyanikoglu
Copy link
Member

Thanks for TObjectPtr update 👍🏻 , I was planning to work on that soon but you were faster :)

However, your commit 4afc5bd will probably mess up the git history, thus I recommend force pushing changes without involving dist folder before I can merge this.

@CanisHelix
Copy link
Contributor Author

CanisHelix commented Mar 5, 2022

No worries, I didn't actually notice the TObjectPtr issues until I built the plugin alone by itself via Jenkins outside of a /plugins/ directory. Removed 4afc5bd from the fork history.

As per https://docs.unrealengine.com/5.0/en-US/MigrationGuide/ updating from Native Pointers to TObjectPtr's. Without this change, errors like `Error: Native pointer usage in member declaration detected [[[AALSBaseCharacter*]]].  This is disallowed for the target/module, consider TObjectPtr as an alternative.` will occur if compiled outside of a path containing `/plugins/`. So if a user migrates to their own project source folder, or once Epic fixes up the TODO in https://github.com/EpicGames/UnrealEngine/blob/5.0.0-preview-1/Engine/Source/Programs/UnrealHeaderTool/Private/HeaderParser.cpp#L4144-L4152 to remove the current exclusion, users will face compilation errors. This commit future proof's this.
@dyanikoglu dyanikoglu merged commit 49e6cc1 into ShadowfallStudios:dev Mar 5, 2022
@dyanikoglu
Copy link
Member

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants