fix(build): fix build/packages issue and update to comply with new c++ standards#365
Merged
dyanikoglu merged 2 commits intoShadowfallStudios:devfrom Mar 5, 2022
CanisHelix:dev
Merged
fix(build): fix build/packages issue and update to comply with new c++ standards#365dyanikoglu merged 2 commits intoShadowfallStudios:devfrom CanisHelix:dev
dyanikoglu merged 2 commits intoShadowfallStudios:devfrom
CanisHelix:dev
Conversation
Add Categories to BP Exposed Functions and Properties. Include missing LocalPlayer include.
Member
|
Thanks for TObjectPtr update 👍🏻 , I was planning to work on that soon but you were faster :) However, your commit 4afc5bd will probably mess up the git history, thus I recommend force pushing changes without involving dist folder before I can merge this. |
Contributor
Author
|
No worries, I didn't actually notice the TObjectPtr issues until I built the plugin alone by itself via Jenkins outside of a |
As per https://docs.unrealengine.com/5.0/en-US/MigrationGuide/ updating from Native Pointers to TObjectPtr's. Without this change, errors like `Error: Native pointer usage in member declaration detected [[[AALSBaseCharacter*]]]. This is disallowed for the target/module, consider TObjectPtr as an alternative.` will occur if compiled outside of a path containing `/plugins/`. So if a user migrates to their own project source folder, or once Epic fixes up the TODO in https://github.com/EpicGames/UnrealEngine/blob/5.0.0-preview-1/Engine/Source/Programs/UnrealHeaderTool/Private/HeaderParser.cpp#L4144-L4152 to remove the current exclusion, users will face compilation errors. This commit future proof's this.
Member
|
Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Categories to BP Exposed Functions and Properties.
Include missing LocalPlayer include.
As per https://docs.unrealengine.com/5.0/en-US/MigrationGuide/ updating from Native Pointers to TObjectPtr's. Without this change, errors like
Error: Native pointer usage in member declaration detected [[[AALSBaseCharacter*]]]. This is disallowed for the target/module, consider TObjectPtr as an alternative.will occur if compiled outside of a path containing/plugins/. So if a user migrates to their own project source folder, or once Epic fixes up the TODO in https://github.com/EpicGames/UnrealEngine/blob/5.0.0-preview-1/Engine/Source/Programs/UnrealHeaderTool/Private/HeaderParser.cpp#L4144-L4152 to remove the current exclusion, users will face compilation errors. This commit future proof's this.