perf: cache available localizations in static let for L10n (#10)#25
Merged
ShadyUnderLight merged 1 commit intomainfrom Apr 20, 2026
Merged
perf: cache available localizations in static let for L10n (#10)#25ShadyUnderLight merged 1 commit intomainfrom
ShadyUnderLight merged 1 commit intomainfrom
Conversation
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复内容
问题:
L10n.localizationCandidates(for:)每次string()/format()调用都重新创建cachedAvailableLocalizations(从Bundle.module.localizations构造Set<String>),而 Localization 在 app 生命周期内永远不会变化,这部分计算完全没必要重复。修复:将
available提升为private static let cachedAvailableLocalizations— 在L10nenum 首次初始化时计算一次,后续string()/format()调用直接读取缓存值,不再重复构造Set。影响范围