Skip to content

perf: cache preferred languages in L10n to avoid recomputing on every call (#16) #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShadyUnderLight merged 1 commit into from
Apr 20, 2026
Merged

perf: cache preferred languages in L10n to avoid recomputing on every call (#16) #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions Sources/ProcessBarMonitor/Localization.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,16 @@ enum L10n {
Set(Bundle.module.localizations.map { $0.lowercased() })
}()

// Cached once — Locale.preferredLanguages is stable for the process lifetime.
private static let cachedPreferredLanguages: [String] = {
Locale.preferredLanguages.map { $0.lowercased() }
}()

private static let bundle: Bundle = {
let moduleBundle = Bundle.module

for preferred in Locale.preferredLanguages.map({ $0.lowercased() }) {
let candidates = localizationCandidates(for: preferred)
for candidate in candidates where cachedAvailableLocalizations.contains(candidate) {
for preferred in cachedPreferredLanguages {
for candidate in localizationCandidates(for: preferred) where cachedAvailableLocalizations.contains(candidate) {
if let path = moduleBundle.path(forResource: candidate, ofType: "lproj"),
let localizedBundle = Bundle(path: path) {
return localizedBundle
Expand All @@ -30,13 +34,11 @@ enum L10n {
String(format: string(key), locale: Locale.current, arguments: arguments)
}

// Candidates are derived from language tags which are stable for the process lifetime.
private static func localizationCandidates(for language: String) -> [String] {
let parts = language.split(separator: "-").map(String.init)
guard !parts.isEmpty else { return [language] }

var candidates: [String] = []
candidates.append(language)
var candidates: [String] = [language]

if parts.count >= 2 {
candidates.append(parts[0] + "-" + parts[1])
Expand Down