feat: support display templates and popup module visibility for issue #48#54
Merged
ShadyUnderLight merged 2 commits intomainfrom Apr 29, 2026
Merged
Conversation
added 2 commits
April 29, 2026 17:45
- Add MenuBarDisplayTemplate enum (minimal/standard/detailed) - Add PopupModuleVisibility OptionSet (sparklines, topCPU, topMemory, temperatureHint, diagnostics) - Both persist to UserDefaults with migration from legacy strings - SettingsView adds template picker and module toggles - MenuBarContentView conditionally renders sections based on moduleVisibility - 10 new unit tests for default values and migration paths
…y section, gate diagnostics button - menuBarTitle now switches on displayTemplate instead of menuBarDisplayMode: minimal = compact (cpu mem temp), standard = labeled (CPU/labeled), detailed = temperatureFirst - Remove duplicate Top Memory section that bypassed moduleVisibility - Gate Copy Diagnostics button behind .diagnostics flag - 3 new tests for displayTemplate default/migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MenuBarDisplayTemplateenum withminimal,standard,detailedcasesPopupModuleVisibilityOptionSet with flags for sparklines, topCPU, topMemory, temperatureHint, diagnosticsmoduleVisibilityAcceptance criteria met
Testing