Standardize Window.onDropFile in JS.#1
Closed
player-03 wants to merge 1 commit intoShaharMS:feature/drop-event-apifrom
Closed
Standardize Window.onDropFile in JS.#1player-03 wants to merge 1 commit intoShaharMS:feature/drop-event-apifrom
Window.onDropFile in JS.#1player-03 wants to merge 1 commit intoShaharMS:feature/drop-event-apifrom
Conversation
Now instead of getting a `FileList` object, you get a string URL just like on other platforms. If the file is an image, this URL can be loaded via `Image.loadFromFile()`, as expected. If not, it can be loaded using any other standard way to load URLs. Since loading is required either way, I don't believe this hurts performance in any meaningful way. However, it does allocate an object URL that won't be deallocated until the page is closed or the user calls `js.html.URL.revokeObjectURL()`. I'm not too worried about this.
This was referenced Oct 10, 2022
Author
|
Now that openfl#1461 is merged, this is redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now instead of getting a
FileListobject, you get a string URL just like on other platforms. If the file is an image, this URL can be loaded viaImage.loadFromFile(), as expected. If not, it can be loaded using any other standard way to load URLs.Since loading is required either way, I don't believe this hurts performance in any meaningful way. However, it does allocate an object URL that won't be deallocated until the page is closed or the user calls
js.html.URL.revokeObjectURL(). I'm not too worried about this.