fix: Add E2E test snapshots and fix coverage check#1
Merged
Conversation
added 5 commits
February 3, 2026 18:21
- Remove __snapshots__ from .gitignore to track Playwright visual regression snapshots - Add all E2E test snapshots for examples - Fix CI coverage check to use coverage-summary.json instead of coverage-final.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes E2E test failures in the CI pipeline caused by missing Playwright visual regression snapshots. Also fixes the coverage threshold check to use the correct coverage summary file.
Type of Change
Changes Made
Testing
Test Coverage
Manual Testing
Ran E2E tests locally to generate and verify snapshots:
\\�ash
npm run test:e2e:update-snapshots
All 28 tests passed
\\
Performance Impact
Breaking Changes
Checklist
pm run lint\ passes)
pm run type-check\ passes)
pm run test\ passes)
pm run build)
Additional Notes
The snapshots were previously gitignored, causing the E2E tests to fail in CI since there were no baseline images to compare against. This is a common mistake when setting up Playwright visual regression tests - the snapshots need to be version controlled.
The coverage check was also broken because \coverage-final.json\ contains per-file coverage data, not the aggregated totals. The correct file is \coverage-summary.json\ which contains the \ otal\ property with line/branch/function/statement percentages.