Skip to content

[Ramses][gravity] Set gravity potential and add it in ghost zones#1016

Merged
tdavidcl merged 13 commits intoShamrock-code:mainfrom
Akos299:features/set-potential-field
Jun 12, 2025
Merged

[Ramses][gravity] Set gravity potential and add it in ghost zones#1016
tdavidcl merged 13 commits intoShamrock-code:mainfrom
Akos299:features/set-potential-field

Conversation

@Akos299
Copy link
Collaborator

@Akos299 Akos299 commented May 31, 2025

No description provided.

@Akos299 Akos299 requested a review from tdavidcl May 31, 2025 08:26
@tdavidcl tdavidcl added the draft label May 31, 2025
@tdavidcl tdavidcl marked this pull request as draft May 31, 2025 17:47
@tdavidcl tdavidcl changed the title [Ramses][gravity] Set gravity potential and ad it in ghost zones [Ramses][gravity] Set gravity potential and add it in ghost zones May 31, 2025
@tdavidcl
Copy link
Member

@Akos299 I had some issue with one of the GitHub runner, I forced the update of your PR to trigger a new/clean workflow.

@tdavidcl
Copy link
Member

From a initial review I will likely approve/merge it tomorrow, the PR is clean.

@github-actions
Copy link
Contributor

Workflow report

workflow report corresponding to commit a1d0905
Commiter email is timothee.davidcleris@proton.me
GitHub page artifact URL GitHub page artifact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
ruff check...............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 0
New warnings : 0
Warnings count : 6339 → 6339 (0.0%)

Detailed changes :

Copy link
Member

@tdavidcl tdavidcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean

@tdavidcl tdavidcl marked this pull request as ready for review June 12, 2025 12:13
@tdavidcl tdavidcl merged commit 02a549b into Shamrock-code:main Jun 12, 2025
40 checks passed
@Akos299 Akos299 deleted the features/set-potential-field branch December 11, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants