Skip to content

[Ramses][DragIntegrator] Ajuste work-group-size#1065

Merged
tdavidcl merged 2 commits intoShamrock-code:mainfrom
Akos299:features/expo-shared-mem-size-fix
Jun 23, 2025
Merged

[Ramses][DragIntegrator] Ajuste work-group-size#1065
tdavidcl merged 2 commits intoShamrock-code:mainfrom
Akos299:features/expo-shared-mem-size-fix

Conversation

@Akos299
Copy link
Collaborator

@Akos299 Akos299 commented Jun 22, 2025

Compute work-group size w.r.t the devices shared memory size and number of dust fluids.
This is validate on Dusty Collision test with 20 dust species.
dusty_collision_test_exp_20f

Even if this fix the precedent issue it's not optimal for large Ndust.

Compute work-group size w.r.t the devices shared memory size
and number of dust fluids.
@Akos299 Akos299 requested a review from tdavidcl June 22, 2025 18:04
Copy link
Member

@tdavidcl tdavidcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A slow fix is better than something broken :)

@github-actions
Copy link
Contributor

Workflow report

workflow report corresponding to commit 91933e3
Commiter email is science.ing.guru24.02@gmail.com
GitHub page artifact URL GitHub page artifact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
ruff check...............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 0
New warnings : 0
Warnings count : 6386 → 6386 (0.0%)

Detailed changes :

@tdavidcl tdavidcl merged commit da75553 into Shamrock-code:main Jun 23, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants