Skip to content

[Base] introduce new log macros to avoid unnecessary formatting#1069

Merged
tdavidcl merged 4 commits intoShamrock-code:mainfrom
tdavidcl:feat/new-log
Jun 27, 2025
Merged

[Base] introduce new log macros to avoid unnecessary formatting#1069
tdavidcl merged 4 commits intoShamrock-code:mainfrom
tdavidcl:feat/new-log

Conversation

@tdavidcl
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

Workflow report

workflow report corresponding to commit 20eee99
Commiter email is timothee.davidcleris@proton.me
GitHub page artifact URL GitHub page artifact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
ruff check...............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 1
New warnings : 25
Warnings count : 6417 → 6441 (0.4%)

Detailed changes :
+ src/shambase/include/shambase/logs/loglevels.hpp:114: warning: Member shamlog_debug_sycl(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:120: warning: Member shamlog_debug_sycl_ln(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:126: warning: Member when_shamlog_debug_sycl (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:149: warning: Member shamlog_debug(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:155: warning: Member shamlog_debug_ln(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:161: warning: Member when_shamlog_debug (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:184: warning: Member shamlog_info(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:190: warning: Member shamlog_info_ln(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:196: warning: Member when_shamlog_info (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:219: warning: Member shamlog_normal(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:225: warning: Member shamlog_normal_ln(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:231: warning: Member when_shamlog_normal (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:254: warning: Member shamlog_warn(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:260: warning: Member shamlog_warn_ln(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:266: warning: Member when_shamlog_warn (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:289: warning: Member shamlog_error(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:295: warning: Member shamlog_error_ln(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:301: warning: Member when_shamlog_error (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:43: warning: Member shamlog_debug_alloc(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:49: warning: Member shamlog_debug_alloc_ln(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:55: warning: Member when_shamlog_debug_alloc (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:79: warning: Member shamlog_debug_mpi(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:85: warning: Member shamlog_debug_mpi_ln(module_name,...) (macro definition) of file loglevels.hpp is not documented.
+ src/shambase/include/shambase/logs/loglevels.hpp:91: warning: Member when_shamlog_debug_mpi (macro definition) of file loglevels.hpp is not documented.
- src/shamcomm/src/logs.cpp:103: warning: Member X (macro definition) of file logs.cpp is not documented.
+ src/shamcomm/src/logs.cpp:44: warning: Member X (macro definition) of file logs.cpp is not documented.

@tdavidcl tdavidcl merged commit 7073760 into Shamrock-code:main Jun 27, 2025
40 checks passed
@tdavidcl tdavidcl deleted the feat/new-log branch June 27, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant