[Patch] add a PatchData function to remove ids

[tdavidcl]

No description provided.

[github-actions]

Workflow report

workflow report corresponding to commit 7201f5d
Commiter email is timothee.davidcleris@proton.me
GitHub page artifact URL GitHub page artifact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
ruff check...............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 38
New warnings : 38
Warnings count : 6781 → 6781 (0.0%)

Detailed changes :

- src/shamrock/include/shamrock/patch/PatchData.hpp:177: warning: Member split_patchdata(std::array< std::reference_wrapper< PatchData >, 8 > pdats, std::array< Tvecbox, 8 > min_box, std::array< Tvecbox, 8 > max_box) (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:180: warning: Member split_patchdata(std::array< std::reference_wrapper< PatchData >, 8 > pdats, std::array< Tvecbox, 8 > min_box, std::array< Tvecbox, 8 > max_box) (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:182: warning: Member append_subset_to(std::vector< u32 > &idxs, PatchData &pdat) (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:183: warning: Member append_subset_to(sycl::buffer< u32 > &idxs, u32 sz, PatchData &pdat) (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:185: warning: Member append_subset_to(std::vector< u32 > &idxs, PatchData &pdat) (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:185: warning: Member get_obj_cnt() (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:186: warning: Member append_subset_to(sycl::buffer< u32 > &idxs, u32 sz, PatchData &pdat) (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:188: warning: Member get_obj_cnt() (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:199: warning: Member memsize() (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:202: warning: Member memsize() (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:212: warning: Member is_empty() (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:214: warning: Member synchronize_buf() (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:215: warning: Member is_empty() (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:217: warning: Member synchronize_buf() (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:222: warning: Member overwrite(PatchData &pdat, u32 obj_cnt) (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:225: warning: Member check_field_type(u32 idx) (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:225: warning: Member overwrite(PatchData &pdat, u32 obj_cnt) (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:228: warning: Member check_field_type(u32 idx) (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:238: warning: Member get_field(u32 idx) (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:241: warning: Member get_field(u32 idx) (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:258: warning: Member get_field_buf_ref(u32 idx) (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:261: warning: Member get_field_buf_ref(u32 idx) (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:302: warning: Member get_field_pointer_span(u32 idx) (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:305: warning: Member get_field_pointer_span(u32 idx) (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:329: warning: Member for_each_field(Functor &&func) (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:332: warning: Member for_each_field(Functor &&func) (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:339: warning: Member operator==(PatchData &p1, PatchData &p2) (friend) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:342: warning: Member operator==(PatchData &p1, PatchData &p2) (friend) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:368: warning: Member serialize_buf(shamalgs::SerializeHelper &serializer) (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:370: warning: Member serialize_buf_byte_size() (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:371: warning: Member serialize_buf(shamalgs::SerializeHelper &serializer) (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:373: warning: Member deserialize_buf(shamalgs::SerializeHelper &serializer, PatchDataLayout &pdl) (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:373: warning: Member serialize_buf_byte_size() (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:375: warning: Member fields_raz() (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:376: warning: Member deserialize_buf(shamalgs::SerializeHelper &serializer, PatchDataLayout &pdl) (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:377: warning: Member has_nan() (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:378: warning: Member fields_raz() (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:380: warning: Member has_nan() (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:391: warning: Member has_inf() (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:394: warning: Member has_inf() (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:405: warning: Member has_nan_or_inf() (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/include/shamrock/patch/PatchData.hpp:408: warning: Member has_nan_or_inf() (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/include/shamrock/patch/PatchData.hpp:439: warning: argument 'pdat' of command @param is not found in the argument list of shamrock::patch::PatchData::fetch_data(std::string key)
+ src/shamrock/include/shamrock/patch/PatchData.hpp:442: warning: argument 'pdat' of command @param is not found in the argument list of shamrock::patch::PatchData::fetch_data(std::string key)
- src/shamrock/include/shamrock/patch/PatchDataField.hpp:466: warning: Member compute_max() (function) of class PatchDataField is not documented.
- src/shamrock/include/shamrock/patch/PatchDataField.hpp:467: warning: Member compute_min() (function) of class PatchDataField is not documented.
- src/shamrock/include/shamrock/patch/PatchDataField.hpp:468: warning: Member compute_sum() (function) of class PatchDataField is not documented.
- src/shamrock/include/shamrock/patch/PatchDataField.hpp:470: warning: Member compute_dot_sum() (function) of class PatchDataField is not documented.
- src/shamrock/include/shamrock/patch/PatchDataField.hpp:472: warning: Member has_nan() (function) of class PatchDataField is not documented.
- src/shamrock/include/shamrock/patch/PatchDataField.hpp:473: warning: Member has_inf() (function) of class PatchDataField is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataField.hpp:474: warning: Member compute_max() (function) of class PatchDataField is not documented.
- src/shamrock/include/shamrock/patch/PatchDataField.hpp:474: warning: Member has_nan_or_inf() (function) of class PatchDataField is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataField.hpp:475: warning: Member compute_min() (function) of class PatchDataField is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataField.hpp:476: warning: Member compute_sum() (function) of class PatchDataField is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataField.hpp:478: warning: Member compute_dot_sum() (function) of class PatchDataField is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataField.hpp:480: warning: Member has_nan() (function) of class PatchDataField is not documented.
- src/shamrock/include/shamrock/patch/PatchDataField.hpp:480: warning: Member mock_field(u64 seed, u32 obj_cnt, std::string name, u32 nvar) (function) of class PatchDataField is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataField.hpp:481: warning: Member has_inf() (function) of class PatchDataField is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataField.hpp:482: warning: Member has_nan_or_inf() (function) of class PatchDataField is not documented.
- src/shamrock/include/shamrock/patch/PatchDataField.hpp:482: warning: Member mock_field(u64 seed, u32 obj_cnt, std::string name, u32 nvar, T vmin, T vmax) (function) of class PatchDataField is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataField.hpp:488: warning: Member mock_field(u64 seed, u32 obj_cnt, std::string name, u32 nvar) (function) of class PatchDataField is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataField.hpp:490: warning: Member mock_field(u64 seed, u32 obj_cnt, std::string name, u32 nvar, T vmin, T vmax) (function) of class PatchDataField is not documented.
- src/shamrock/include/shamrock/patch/PatchDataField.hpp:606: warning: Compound PatchDataRangeCheckError is not documented.
- src/shamrock/include/shamrock/patch/PatchDataField.hpp:608: warning: Member PatchDataRangeCheckError(const char *message) (function) of class PatchDataRangeCheckError is not documented.
- src/shamrock/include/shamrock/patch/PatchDataField.hpp:610: warning: Member PatchDataRangeCheckError(const std::string &message) (function) of class PatchDataRangeCheckError is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataField.hpp:614: warning: Compound PatchDataRangeCheckError is not documented.
- src/shamrock/include/shamrock/patch/PatchDataField.hpp:614: warning: Member what() const noexcept override (function) of class PatchDataRangeCheckError is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataField.hpp:616: warning: Member PatchDataRangeCheckError(const char *message) (function) of class PatchDataRangeCheckError is not documented.
- src/shamrock/include/shamrock/patch/PatchDataField.hpp:617: warning: Member msg_ (variable) of class PatchDataRangeCheckError is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataField.hpp:618: warning: Member PatchDataRangeCheckError(const std::string &message) (function) of class PatchDataRangeCheckError is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataField.hpp:622: warning: Member what() const noexcept override (function) of class PatchDataRangeCheckError is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataField.hpp:625: warning: Member msg_ (variable) of class PatchDataRangeCheckError is not documented.
- src/shamrock/src/patch/PatchData.cpp:267: warning: Member split_patchdata(std::array< std::reference_wrapper< PatchData >, 8 > pdats, std::array< T, 8 > min_box, std::array< T, 8 > max_box) (function) of class shamrock::patch::PatchData is not documented.
+ src/shamrock/src/patch/PatchData.cpp:275: warning: Member split_patchdata(std::array< std::reference_wrapper< PatchData >, 8 > pdats, std::array< T, 8 > min_box, std::array< T, 8 > max_box) (function) of class shamrock::patch::PatchData is not documented.
- src/shamrock/src/patch/PatchDataField.cpp:489: warning: Member obj_mock_cnt (variable) of file PatchDataField.cpp is not documented.
+ src/shamrock/src/patch/PatchDataField.cpp:530: warning: Member obj_mock_cnt (variable) of file PatchDataField.cpp is not documented.