Skip to content

[Algs] replace a allgather by work duplication#1090

Merged
tdavidcl merged 3 commits intoShamrock-code:mainfrom
tdavidcl:feat/allgather-vector-opti
Jul 5, 2025
Merged

[Algs] replace a allgather by work duplication#1090
tdavidcl merged 3 commits intoShamrock-code:mainfrom
tdavidcl:feat/allgather-vector-opti

Conversation

@tdavidcl
Copy link
Member

@tdavidcl tdavidcl commented Jul 4, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

Workflow report

workflow report corresponding to commit 8efac00
Commiter email is timothee.davidcleris@proton.me
GitHub page artifact URL GitHub page artifact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
ruff check...............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 1
New warnings : 1
Warnings count : 6790 → 6790 (0.0%)

Detailed changes :
+ src/shamalgs/include/shamalgs/collective/exchanges.hpp:144: warning: Member vector_allgatherv(const std::vector< T > &send_vec, std::vector< T > &recv_vec, const MPI_Comm comm) (function) of namespace shamalgs::collective is not documented.
- src/shamalgs/include/shamalgs/collective/exchanges.hpp:158: warning: Member vector_allgatherv(const std::vector< T > &send_vec, std::vector< T > &recv_vec, const MPI_Comm comm) (function) of namespace shamalgs::collective is not documented.

@tdavidcl tdavidcl merged commit dc0be12 into Shamrock-code:main Jul 5, 2025
40 checks passed
@tdavidcl tdavidcl deleted the feat/allgather-vector-opti branch July 5, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant