[Solvergraph] pullback new modules for ghost zone extractions#1192
Merged
tdavidcl merged 4 commits intoShamrock-code:mainfrom Aug 19, 2025
Merged
[Solvergraph] pullback new modules for ghost zone extractions#1192tdavidcl merged 4 commits intoShamrock-code:mainfrom
tdavidcl merged 4 commits intoShamrock-code:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @tdavidcl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces significant refactoring within the solvergraph module to enhance the handling and abstraction of distributed patch data layers and buffers. It formalizes the interaction with patch data through a new interface, IPatchDataLayerRefs, and updates existing components to adhere to this new design. This change improves modularity and prepares the codebase for more robust ghost zone extraction mechanisms by providing a unified way to manage distributed data references.
Highlights
- New Interface for Patch Data Layers: Introduced IPatchDataLayerRefs to provide a polymorphic interface for accessing and managing distributed references to PatchDataLayer objects.
- Refactored Patch Data Handling: PatchDataLayerEdge and PatchDataLayerRefs now implement the IPatchDataLayerRefs interface, centralizing how patch data is accessed and modified.
- Updated Data Copying Logic: The CopyPatchDataLayerFields module has been updated to utilize the new IPatchDataLayerRefs interface, promoting better encapsulation and consistency.
- New Distributed Buffer Management: Added DDSharedBuffers for managing distributed device buffers, laying groundwork for efficient data handling, potentially for ghost zone data.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new interface, IPatchDataLayerRefs, to abstract away concrete data layer implementations, which is a positive change for modularity. The refactoring touches several components, including CopyPatchDataLayerFields, PatchDataLayerEdge, and PatchDataLayerRefs.
My review focuses on ensuring the new abstraction is used correctly and consistently. I've identified a few areas for improvement:
- There's a potential runtime issue in
CopyPatchDataLayerFieldswhere theset_edgesmethod signature is more generic than its implementation, creating a misleading contract. - There are opportunities to improve encapsulation by making data members private and using accessors provided by the new interface.
- I've also suggested adhering to C++ best practices, such as using the
overridespecifier for virtual functions and ensuring base classes with virtual functions have virtual destructors.
Overall, these changes are a good step forward. Addressing the feedback will improve the code's robustness and maintainability.
src/shamrock/include/shamrock/solvergraph/CopyPatchDataLayerFields.hpp
Outdated
Show resolved
Hide resolved
src/shamrock/include/shamrock/solvergraph/PatchDataLayerEdge.hpp
Outdated
Show resolved
Hide resolved
src/tests/shamrock/solvergraph/CopyPatchDataLayerField_tests.cpp
Outdated
Show resolved
Hide resolved
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a significant refactoring by creating a new IPatchDataLayerRefs interface to abstract the handling of patch data layer references. PatchDataLayerEdge and PatchDataLayerRefs are updated to implement this new interface, leading to cleaner and more polymorphic code. The changes are well-implemented across the affected files, including updates to tests. I have a couple of minor suggestions for CopyPatchDataLayerFields.hpp to improve include hygiene and const-correctness.
src/shamrock/include/shamrock/solvergraph/CopyPatchDataLayerFields.hpp
Outdated
Show resolved
Hide resolved
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a significant refactoring by creating an IPatchDataLayerRefs interface to abstract PatchDataLayerEdge and PatchDataLayerRefs. This improves modularity and prepares for new features like ghost zone extractions. The changes also improve const correctness in PatchDataLayer and PatchDataLayerLayout.
My review focuses on performance and correctness. I've suggested passing string parameters by const reference to avoid unnecessary copies. I also found a potential issue in PatchDataLayerEdge::free_alloc where a member holding references isn't cleared, which could lead to dangling references.
Comment on lines
+77
to
+80
| inline virtual void free_alloc() override { | ||
| patchdatas = {}; | ||
| layout = {}; | ||
| } |
Contributor
There was a problem hiding this comment.
The free_alloc method should also clear patchdatas_refs. After patchdatas is cleared, patchdatas_refs will contain dangling references to the destroyed PatchDataLayer objects, which can lead to undefined behavior if accessed later.
inline virtual void free_alloc() override {
patchdatas = {};
patchdatas_refs = {};
layout = {};
}
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and well-executed refactoring. By creating the IPatchDataLayerRefs interface, the code now benefits from better abstraction and decoupling. The changes also improve const-correctness and performance by using const references for string parameters. Moving the implementation of CopyPatchDataLayerFields to a separate .cpp file is a good move for maintainability and reducing compile times. I have one suggestion to improve encapsulation in PatchDataLayerRefs.
Contributor
Workflow reportworkflow report corresponding to commit 18c1b80 Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportNo relevant changes found. You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review. Doxygen diff with
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.