[Ramses] replace GZ finder by solvergraph modules#1214
Merged
tdavidcl merged 5 commits intoShamrock-code:mainfrom Aug 24, 2025
Merged
[Ramses] replace GZ finder by solvergraph modules#1214tdavidcl merged 5 commits intoShamrock-code:mainfrom
tdavidcl merged 5 commits intoShamrock-code:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @tdavidcl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly refactors the ghost zone generation mechanism within the Ramses model. It transitions from a custom, imperative approach to a more modular and extensible design by integrating new solvergraph modules. Specifically, it introduces dedicated modules for identifying ghost layer candidates and subsequently finding the precise indices of cells within these layers, thereby enhancing the clarity and maintainability of the ghost zone construction process.
Highlights
- Core Refactoring of Ghost Zone Generation: The previous custom implementation for finding ghost zones has been replaced with a more structured and modular approach leveraging the
shamrock/solvergraphframework. - Introduction of New Solvergraph Modules: Two new solvergraph modules,
FindGhostLayerCandidatesandFindGhostLayerIndices, have been introduced to encapsulate the logic for identifying potential ghost layer regions and then determining the exact cell indices within those layers. - Integration into GhostZones Module: The
GhostZones.cppfile has been updated to utilize these new solvergraph modules, streamlining the ghost cell building process and reducing direct low-level SYCL buffer operations. - Enhanced Solvergraph Data Flow: A new
SerialPatchTreeRefEdgetype has been added to the solvergraph system, enabling theSerialPatchTreeto be passed as a data edge within the computational graph.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the ghost zone generation logic by replacing a monolithic implementation with new, modular solver graph nodes: FindGhostLayerCandidates and FindGhostLayerIndices. This is a good architectural improvement that increases modularity and aligns with the solver graph framework. The changes look solid, but I've identified a couple of areas for improvement: some leftover dead code in GhostZones.cpp and an incomplete placeholder implementation in FindGhostLayerIndices.cpp. Addressing these points will improve the code quality.
Comment on lines
+112
to
+114
| std::string shammodels::basegodunov::modules::FindGhostLayerIndices<TgridVec>::_impl_get_tex() { | ||
| return "TODO"; | ||
| } |
Contributor
There was a problem hiding this comment.
The _impl_get_tex function is currently a placeholder returning "TODO". This should be implemented to provide the LaTeX representation for this solver graph node, for consistency with other nodes like FindGhostLayerCandidates.
Contributor
Workflow reportworkflow report corresponding to commit 995f0de Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportNo relevant changes found. You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review. Doxygen diff with
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.