[Scheduler] rename pdl to pdl_old to prepare #1531

[tdavidcl]

This PR rename pdl() to pdl_old() and get_layout_ptr() to get_layout_ptr_old().

Any other changes is not intended and should be reported.

[gemini-code-assist]

Summary of Changes

Hello @tdavidcl, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a widespread refactoring by renaming two key methods, pdl() to pdl_old() and get_layout_ptr() to get_layout_ptr_old(). This change is a foundational step to clear the original method names for a new implementation, as part of a larger development effort. The modifications are purely structural, ensuring that existing functionality remains intact under new names without altering the current behavior of the system.

Highlights

• Method Renaming: The pdl() method has been systematically renamed to pdl_old() across numerous files to denote its legacy status.
• Layout Pointer Renaming: The get_layout_ptr() method has been renamed to get_layout_ptr_old(), indicating a similar deprecation or preparation for a new implementation.
• Preparatory Refactoring: These renamings are explicitly stated as a preparatory step for an upcoming change, likely a new implementation of pdl() and get_layout_ptr() as indicated by the reference to [Patch] Layers: Add layers in layout, and replace it in scheduler #1531.

Changelog

• src/shammodels/common/include/shammodels/common/setup/modifiers.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/gsph/include/shammodels/gsph/Model.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/gsph/include/shammodels/gsph/modules/GSPHGhostHandler.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/gsph/include/shammodels/gsph/modules/GSPHUtilities.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/gsph/src/Model.cpp
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/gsph/src/Solver.cpp
  • Updated calls to sched.pdl() or scheduler().pdl() to pdl_old().
• src/shammodels/gsph/src/modules/GSPHGhostHandler.cpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/gsph/src/modules/UpdateDerivs.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
• src/shammodels/gsph/src/modules/io/VTKDump.cpp
  • Updated calls to sched.pdl() or scheduler().pdl() to pdl_old().
• src/shammodels/nbody/src/models/nbody_selfgrav.cpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/nbody/src/setup/nbody_setup.cpp
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/ramses/include/shammodels/ramses/Model.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/ramses/src/Model.cpp
  • Updated calls to solver.scheduler().pdl() to solver.scheduler().pdl_old().
• src/shammodels/ramses/src/Solver.cpp
  • Updated calls to scheduler().get_layout_ptr() to scheduler().get_layout_ptr_old().
• src/shammodels/ramses/src/modules/AMRSetup.cpp
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
• src/shammodels/ramses/src/modules/AnalysisSodTube.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
• src/shammodels/ramses/src/modules/ComputeCFL.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
• src/shammodels/ramses/src/modules/DragIntegrator.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
• src/shammodels/ramses/src/modules/TimeIntegrator.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
• src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/include/shammodels/sph/Model.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
• src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/include/shammodels/sph/modules/AnalysisBarycenter.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/include/shammodels/sph/modules/AnalysisEnergyKinetic.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/include/shammodels/sph/modules/AnalysisEnergyPotential.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/include/shammodels/sph/modules/AnalysisTotalMomentum.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/include/shammodels/sph/modules/setup/GeneratorFromOtherContext.hpp
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
• src/shammodels/sph/include/shammodels/sph/modules/setup/GeneratorLatticeCubic.hpp
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/include/shammodels/sph/modules/setup/GeneratorLatticeHCP.hpp
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/src/Model.cpp
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/src/Solver.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
  • Updated calls to scheduler().get_layout_ptr() to scheduler().get_layout_ptr_old().
• src/shammodels/sph/src/modules/AnalysisDisc.cpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/src/modules/AnalysisSodTube.cpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/src/modules/ConservativeCheck.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
• src/shammodels/sph/src/modules/DiffOperator.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
• src/shammodels/sph/src/modules/DiffOperatorDtDivv.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
• src/shammodels/sph/src/modules/ExternalForces.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
• src/shammodels/sph/src/modules/SPHSetup.cpp
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
• src/shammodels/sph/src/modules/SinkParticlesUpdate.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
• src/shammodels/sph/src/modules/UpdateDerivs.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
• src/shammodels/sph/src/modules/UpdateViscosity.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
• src/shammodels/sph/src/modules/io/VTKDump.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
• src/shammodels/sph/src/modules/setup/GeneratorMCDisc.cpp
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/src/modules/setup/ModifierApplyCustomWarp.cpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/src/modules/setup/ModifierApplyDiscWarp.cpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/src/modules/setup/ModifierFilter.cpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/src/modules/setup/ModifierOffset.cpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/sph/src/modules/setup/ModifierSplitPart.cpp
  • Updated calls to sched.pdl() to sched.pdl_old().
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
• src/shammodels/zeus/include/shammodels/zeus/Model.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shammodels/zeus/src/modules/AnalysisSodTube.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
• src/shammodels/zeus/src/modules/GhostZones.cpp
  • Updated calls to scheduler().pdl() to scheduler().pdl_old().
• src/shamrock/include/shamrock/amr/AMRGrid.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
• src/shamrock/include/shamrock/legacy/io/dump.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shamrock/include/shamrock/legacy/patch/comm/patch_object_mover.hpp
  • Updated calls to sched.pdl() to sched.pdl_old().
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
• src/shamrock/include/shamrock/legacy/patch/interfaces/interface_handler_impl.hpp
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
• src/shamrock/include/shamrock/legacy/patch/interfaces/interface_handler_impl/interface_handler_impl_tree.hpp
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
• src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp
  • Renamed pdl() method to pdl_old().
  • Renamed get_layout_ptr() method to get_layout_ptr_old().
  • Updated internal calls to the renamed methods.
• src/shamrock/include/shamrock/scheduler/ReattributeDataUtility.hpp
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
  • Updated calls to sched.pdl() to sched.pdl_old().
• src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp
  • Updated the return mechanism for pdl to use shambase::get_check_ref(pdl).
• src/shamrock/src/legacy/patch/utility/merged_patch.cpp
  • Updated calls to sched.get_layout_ptr() to sched.get_layout_ptr_old().
• src/shamrock/src/scheduler/PatchScheduler.cpp
  • Updated calls to get_layout_ptr() to get_layout_ptr_old().
  • Updated calls to pdl() to pdl_old().

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly renames pdl() to pdl_old() and get_layout_ptr() to get_layout_ptr_old() across numerous files. The changes are mostly consistent with the stated goal. However, there is an unintended functional change in ShamrockCtx.hpp that, while beneficial, should be in a separate PR. Additionally, widespread formatting changes have been introduced, likely by an auto-formatter, which should be separated from the renaming effort to maintain a clean commit history.

[github-actions]

Thanks @tdavidcl for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label light-ci to only trigger a reduced & faster version of the CI (need the full one before merge).
5 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

[github-actions]

Workflow report

workflow report corresponding to commit 79b7043
Commiter email is timothee.davidcleris@proton.me
GitHub page artifact URL GitHub page artifact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Clang-tidy diff report

351 warnings generated.
Suppressed 352 warnings (351 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

354 warnings generated.
Suppressed 355 warnings (354 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

356 warnings generated.
Suppressed 357 warnings (355 in non-user code, 1 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

354 warnings generated.
Suppressed 355 warnings (354 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

356 warnings generated.
Suppressed 357 warnings (356 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

362 warnings generated.
Suppressed 363 warnings (360 in non-user code, 2 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

354 warnings generated.
Suppressed 355 warnings (354 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

364 warnings generated.
Suppressed 365 warnings (364 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

380 warnings generated.
Suppressed 381 warnings (379 in non-user code, 1 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

397 warnings generated.
Suppressed 398 warnings (395 in non-user code, 2 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

395 warnings generated.
Suppressed 396 warnings (395 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

399 warnings generated.
Suppressed 400 warnings (399 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

398 warnings generated.
Suppressed 399 warnings (398 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

412 warnings generated.
Suppressed 413 warnings (411 in non-user code, 1 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

414 warnings generated.
Suppressed 415 warnings (412 in non-user code, 2 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

375 warnings generated.
Suppressed 376 warnings (374 in non-user code, 1 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

444 warnings generated.
Suppressed 445 warnings (442 in non-user code, 2 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

444 warnings generated.
Suppressed 445 warnings (444 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

444 warnings generated.
Suppressed 445 warnings (444 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

448 warnings generated.
Suppressed 449 warnings (446 in non-user code, 2 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

444 warnings generated.
Suppressed 445 warnings (444 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

444 warnings generated.
Suppressed 445 warnings (444 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

/__w/Shamrock/Shamrock/src/shamrock/include/shamrock/amr/AMRCell.hpp:21:10: error: 'shammodels/common/amr/AMRBlock.hpp' file not found [clang-diagnostic-error]
   21 | #include "shammodels/common/amr/AMRBlock.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

152 warnings and 1 error generated.
Error while processing /__w/Shamrock/Shamrock/src/shamrock/include/shamrock/amr/AMRGrid.hpp.
Suppressed 152 warnings (152 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler errors, but -fix-errors was not specified.
Fixes have NOT been applied.

Found compiler error(s).

430 warnings generated.
Suppressed 431 warnings (430 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

415 warnings generated.
Suppressed 416 warnings (413 in non-user code, 2 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

434 warnings generated.
Suppressed 435 warnings (434 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

/__w/Shamrock/Shamrock/src/shammodels/nbody/src/models/nbody_selfgrav.cpp:523:9: warning: 'reatribute_particles<hipsycl::sycl::vec<float, 3>>' is deprecated: Legacy module [clang-diagnostic-deprecated-declarations]
  523 |         reatribute_particles(sched, sptree, periodic_bc);
      |         ^
/__w/Shamrock/Shamrock/src/shammodels/nbody/src/models/nbody_selfgrav.cpp:448:87: note: while substituting into a lambda expression here
  448 |     auto leapfrog_lambda = [&](flt old_time, bool do_force, bool do_corrector) -> flt {
      |                                                                                       ^
/__w/Shamrock/Shamrock/src/shammodels/nbody/src/models/nbody_selfgrav.cpp:1172:31: note: in instantiation of member function 'models::nbody::Nbody_SelfGrav<float>::evolve' requested here
 1172 | template class models::nbody::Nbody_SelfGrav<f32>;
      |                               ^
/__w/Shamrock/Shamrock/src/shamrock/include/shamrock/legacy/patch/comm/patch_object_mover.hpp:102:3: note: 'reatribute_particles<hipsycl::sycl::vec<float, 3>>' has been explicitly marked deprecated here
  102 | [[deprecated("Legacy module")]]
      |   ^
/__w/Shamrock/Shamrock/src/shammodels/nbody/src/models/nbody_selfgrav.cpp:940:45: warning: 'tree_recv_map' is deprecated: Please use CommunicationBuffer & SerializeHelper instead [clang-diagnostic-deprecated-declarations]
  940 |                     std::get<0>(interf_hndl.tree_recv_map[id_patch][interf_id]));
      |                                             ^
/__w/Shamrock/Shamrock/src/shammodels/nbody/src/models/nbody_selfgrav.cpp:922:88: note: while substituting into a lambda expression here
  922 |         sched.for_each_patch_data([&](u64 id_patch, Patch cur_p, PatchDataLayer &pdat) {
      |                                                                                        ^
/__w/Shamrock/Shamrock/src/shammodels/nbody/src/models/nbody_selfgrav.cpp:448:87: note: while substituting into a lambda expression here
  448 |     auto leapfrog_lambda = [&](flt old_time, bool do_force, bool do_corrector) -> flt {
      |                                                                                       ^
/__w/Shamrock/Shamrock/src/shammodels/nbody/src/models/nbody_selfgrav.cpp:1172:31: note: in instantiation of member function 'models::nbody::Nbody_SelfGrav<float>::evolve' requested here
 1172 | template class models::nbody::Nbody_SelfGrav<f32>;
      |                               ^
/__w/Shamrock/Shamrock/src/shamrock/include/shamrock/legacy/patch/interfaces/interface_handler_impl/interface_handler_impl_tree.hpp:136:7: note: 'tree_recv_map' has been explicitly marked deprecated here
  136 |     [[deprecated("Please use CommunicationBuffer & SerializeHelper instead")]]
      |       ^

476 warnings generated.
Suppressed 475 warnings (465 in non-user code, 9 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

/__w/Shamrock/Shamrock/src/shamrock/include/shamrock/io/LegacyVtkWritter.hpp:458:9: warning: 3 uninitialized fields at the end of the constructor call [clang-analyzer-optin.cplusplus.UninitializedObject]
  458 |         LegacyVtkWritter(LegacyVtkWritter &&other)
      |         ^
/__w/Shamrock/Shamrock/src/shambase/include/shambase/time.hpp:100:13: note: uninitialized field 'this->timer.nanosec'
  100 |         f64 nanosec; ///< Time in nanosecond
      |             ^~~~~~~
/__w/Shamrock/Shamrock/src/shamrock/include/shamrock/io/LegacyVtkWritter.hpp:169:13: note: uninitialized field 'this->points_count'
  169 |         u64 points_count;
      |             ^~~~~~~~~~~~
/__w/Shamrock/Shamrock/src/shamrock/include/shamrock/io/LegacyVtkWritter.hpp:172:13: note: uninitialized field 'this->cells_count'
  172 |         u64 cells_count;
      |             ^~~~~~~~~~~
/__w/Shamrock/Shamrock/src/shammodels/gsph/src/modules/io/VTKDump.cpp:154:31: note: 'has_uint' is false
  154 |         const u32 iuint     = has_uint ? pdl.get_field_idx<Tscal>(gsph::names::newtonian::uint) : 0;
      |                               ^~~~~~~~
/__w/Shamrock/Shamrock/src/shammodels/gsph/src/modules/io/VTKDump.cpp:154:31: note: '?' condition is false
/__w/Shamrock/Shamrock/src/shammodels/gsph/src/modules/io/VTKDump.cpp:156:46: note: Calling 'start_dump<hipsycl::sycl::vec<double, 3>>'
  156 |         shamrock::LegacyVtkWritter writter = start_dump<Tvec>(scheduler(), filename);
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/Shamrock/Shamrock/src/shammodels/gsph/src/modules/io/VTKDump.cpp:36:9: note: Assuming 'loglevel' is < 'logval'
   36 |         shamlog_debug_mpi_ln("gsph::vtk", "rank count =", num_obj);
      |         ^
/__w/Shamrock/Shamrock/src/shambase/include/shambase/logs/loglevels.hpp:89:9: note: expanded from macro 'shamlog_debug_mpi_ln'
   89 |     if (shambase::logs::details::loglevel >= LogLevel_DebugMPI::logval) {                          \
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/Shamrock/Shamrock/src/shammodels/gsph/src/modules/io/VTKDump.cpp:36:9: note: Taking false branch
   36 |         shamlog_debug_mpi_ln("gsph::vtk", "rank count =", num_obj);
      |         ^
/__w/Shamrock/Shamrock/src/shambase/include/shambase/logs/loglevels.hpp:89:5: note: expanded from macro 'shamlog_debug_mpi_ln'
   89 |     if (shambase::logs::details::loglevel >= LogLevel_DebugMPI::logval) {                          \
      |     ^
/__w/Shamrock/Shamrock/src/shammodels/gsph/src/modules/io/VTKDump.cpp:43:16: note: Calling move constructor for 'LegacyVtkWritter'
   43 |         return writer;
      |                ^~~~~~
/__w/Shamrock/Shamrock/src/shamrock/include/shamrock/io/LegacyVtkWritter.hpp:458:9: note: 3 uninitialized fields at the end of the constructor call
  458 |         LegacyVtkWritter(LegacyVtkWritter &&other)
      |         ^~~~~~~~~~~~~~~~

434 warnings generated.
Suppressed 435 warnings (434 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

464 warnings generated.
Suppressed 465 warnings (464 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

410 warnings generated.
Suppressed 411 warnings (410 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

446 warnings generated.
Suppressed 447 warnings (444 in non-user code, 2 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

399 warnings generated.
Suppressed 400 warnings (399 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

495 warnings generated.
Suppressed 496 warnings (495 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

374 warnings generated.
Suppressed 375 warnings (374 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

434 warnings generated.
Suppressed 435 warnings (434 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

399 warnings generated.
Suppressed 400 warnings (399 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

434 warnings generated.
Suppressed 435 warnings (434 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

378 warnings generated.
Suppressed 379 warnings (378 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

360 warnings generated.
Suppressed 361 warnings (357 in non-user code, 3 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

354 warnings generated.
Suppressed 355 warnings (352 in non-user code, 2 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

366 warnings generated.
Suppressed 367 warnings (366 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

/__w/Shamrock/Shamrock/src/shamrock/include/shamrock/scheduler/ReattributeDataUtility.hpp:133:29: warning: redundant boolean literal in if statement condition [readability-simplify-boolean-expr]
  133 |                         if (false) {
      |                         ~~~~^~~~~~~~
  134 | 
  135 |                             const u32 cnt = pdat.get_obj_cnt();
      |                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  136 | 
  137 |                             for (u32 i = cnt - 1; i < cnt; i--) {
      |                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  138 |                                 u64 new_pid = nid[i];
      |                                 ~~~~~~~~~~~~~~~~~~~~~
  139 |                                 if (current_pid != new_pid) {
      |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  140 | 
  141 |                                     if (!part_exchange.has_key(current_pid, new_pid)) {
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  142 |                                         part_exchange.add_obj(
      |                                         ~~~~~~~~~~~~~~~~~~~~~~
  143 |                                             current_pid,
      |                                             ~~~~~~~~~~~~
  144 |                                             new_pid,
      |                                             ~~~~~~~~
  145 |                                             PatchDataLayer(sched.get_layout_ptr_old()));
      |                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  146 |                                     }
      |                                     ~
  147 | 
  148 |                                     part_exchange.for_each(
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~
/__w/Shamrock/Shamrock/src/shamrock/include/shamrock/scheduler/ReattributeDataUtility.hpp:133:25: note: FIX-IT applied suggested code changes
  133 |                         if (false) {
      |                         ^

354 warnings generated.
clang-tidy applied 1 of 1 suggested fixes.
Suppressed 354 warnings (353 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

375 warnings generated.
Suppressed 376 warnings (369 in non-user code, 6 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

351 warnings generated.
Suppressed 352 warnings (346 in non-user code, 5 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

502 warnings generated.
Suppressed 503 warnings (502 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

381 warnings generated.
Suppressed 382 warnings (376 in non-user code, 5 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

441 warnings generated.
Suppressed 442 warnings (441 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

435 warnings generated.
Suppressed 436 warnings (435 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

383 warnings generated.
Suppressed 384 warnings (383 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

507 warnings generated.
Suppressed 508 warnings (502 in non-user code, 5 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

722 warnings generated.
Suppressed 723 warnings (722 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

498 warnings generated.
Suppressed 499 warnings (497 in non-user code, 1 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

380 warnings generated.
Suppressed 381 warnings (378 in non-user code, 2 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

540 warnings generated.
Suppressed 541 warnings (540 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

405 warnings generated.
Suppressed 406 warnings (400 in non-user code, 5 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

733 warnings generated.
Suppressed 734 warnings (641 in non-user code, 92 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

1104 warnings generated.
Suppressed 1105 warnings (1101 in non-user code, 3 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

576 warnings generated.
Suppressed 577 warnings (570 in non-user code, 6 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

632 warnings generated.
Suppressed 633 warnings (626 in non-user code, 6 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

865 warnings generated.
Suppressed 866 warnings (852 in non-user code, 13 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

Suggested changes

Detailed changes :

diff --git a/src/shamrock/include/shamrock/scheduler/ReattributeDataUtility.hpp b/src/shamrock/include/shamrock/scheduler/ReattributeDataUtility.hpp
index 18d9b396..db5f5891 100644
--- a/src/shamrock/include/shamrock/scheduler/ReattributeDataUtility.hpp
+++ b/src/shamrock/include/shamrock/scheduler/ReattributeDataUtility.hpp
@@ -130,31 +130,7 @@ namespace shamrock {
 
                         sycl::host_accessor nid{new_pid.get(current_pid), sycl::read_only};
 
-                        if (false) {
-
-                            const u32 cnt = pdat.get_obj_cnt();
-
-                            for (u32 i = cnt - 1; i < cnt; i--) {
-                                u64 new_pid = nid[i];
-                                if (current_pid != new_pid) {
-
-                                    if (!part_exchange.has_key(current_pid, new_pid)) {
-                                        part_exchange.add_obj(
-                                            current_pid,
-                                            new_pid,
-                                            PatchDataLayer(sched.get_layout_ptr_old()));
-                                    }
-
-                                    part_exchange.for_each(
-                                        [&](u64 _old_id, u64 _new_id, PatchDataLayer &pdat_int) {
-                                            if (_old_id == current_pid && _new_id == new_pid) {
-                                                pdat.extract_element(i, pdat_int);
-                                                histogram_extract[current_pid]++;
-                                            }
-                                        });
-                                }
-                            }
-                        } else {
+                        {
                             std::vector<u32> keep_ids;
                             std::unordered_map<u64, std::vector<u32>> extract_indexes;
 

# Doxygen diff with `main` Removed warnings : 51 New warnings : 51 Warnings count : 8183 → 8183 (0.0%)

Detailed changes :

- src/shammodels/common/include/shammodels/common/setup/modifiers.hpp:139: warning: Member get_sum(PatchScheduler &sched, std::string name) (function) of namespace generic::setup::modifiers is not documented.
+ src/shammodels/common/include/shammodels/common/setup/modifiers.hpp:141: warning: Member get_sum(PatchScheduler &sched, std::string name) (function) of namespace generic::setup::modifiers is not documented.
- src/shammodels/common/include/shammodels/common/setup/modifiers.hpp:60: warning: Member set_value_in_sphere(PatchScheduler &sched, T val, std::string name, vec center, shambase::VecComponent< vec > radius) (function) of namespace generic::setup::modifiers is not documented.
+ src/shammodels/common/include/shammodels/common/setup/modifiers.hpp:61: warning: Member set_value_in_sphere(PatchScheduler &sched, T val, std::string name, vec center, shambase::VecComponent< vec > radius) (function) of namespace generic::setup::modifiers is not documented.
- src/shammodels/common/include/shammodels/common/setup/modifiers.hpp:97: warning: Member pertub_eigenmode_wave(PatchScheduler &sched, std::tuple< flt, flt > ampls, sycl::vec< flt, 3 > k, flt phase) (function) of namespace generic::setup::modifiers is not documented.
+ src/shammodels/common/include/shammodels/common/setup/modifiers.hpp:99: warning: Member pertub_eigenmode_wave(PatchScheduler &sched, std::tuple< flt, flt > ampls, sycl::vec< flt, 3 > k, flt phase) (function) of namespace generic::setup::modifiers is not documented.
- src/shammodels/sph/src/Model.cpp:709: warning: Compound BigDiscUtils is not documented.
- src/shammodels/sph/src/Model.cpp:711: warning: Member Tscal (typedef) of class BigDiscUtils is not documented.
- src/shammodels/sph/src/Model.cpp:712: warning: Member Out (typedef) of class BigDiscUtils is not documented.
+ src/shammodels/sph/src/Model.cpp:713: warning: Compound BigDiscUtils is not documented.
- src/shammodels/sph/src/Model.cpp:714: warning: Compound BigDiscUtils::DiscIterator is not documented.
+ src/shammodels/sph/src/Model.cpp:715: warning: Member Tscal (typedef) of class BigDiscUtils is not documented.
+ src/shammodels/sph/src/Model.cpp:716: warning: Member Out (typedef) of class BigDiscUtils is not documented.
+ src/shammodels/sph/src/Model.cpp:718: warning: Compound BigDiscUtils::DiscIterator is not documented.
- src/shammodels/sph/src/Model.cpp:737: warning: Member DiscIterator(Tvec center, Tscal central_mass, u64 Npart, Tscal r_in, Tscal r_out, Tscal disc_mass, Tscal p, Tscal H_r_in, Tscal q, Tscal G, std::mt19937 eng, std::function< Tscal(Tscal)> sigma_profile, std::function< Tscal(Tscal)> cs_profile, std::function< Tscal(Tscal)> rot_profile) (function) of class BigDiscUtils::DiscIterator is not documented.
+ src/shammodels/sph/src/Model.cpp:741: warning: Member DiscIterator(Tvec center, Tscal central_mass, u64 Npart, Tscal r_in, Tscal r_out, Tscal disc_mass, Tscal p, Tscal H_r_in, Tscal q, Tscal G, std::mt19937 eng, std::function< Tscal(Tscal)> sigma_profile, std::function< Tscal(Tscal)> cs_profile, std::function< Tscal(Tscal)> rot_profile) (function) of class BigDiscUtils::DiscIterator is not documented.
- src/shammodels/sph/src/Model.cpp:762: warning: Member is_done() (function) of class BigDiscUtils::DiscIterator is not documented.
- src/shammodels/sph/src/Model.cpp:764: warning: Member next() (function) of class BigDiscUtils::DiscIterator is not documented.
+ src/shammodels/sph/src/Model.cpp:766: warning: Member is_done() (function) of class BigDiscUtils::DiscIterator is not documented.
+ src/shammodels/sph/src/Model.cpp:768: warning: Member next() (function) of class BigDiscUtils::DiscIterator is not documented.
- src/shammodels/sph/src/Model.cpp:827: warning: Member next_n(u32 nmax) (function) of class BigDiscUtils::DiscIterator is not documented.
+ src/shammodels/sph/src/Model.cpp:831: warning: Member next_n(u32 nmax) (function) of class BigDiscUtils::DiscIterator is not documented.
- src/shamrock/include/shamrock/legacy/patch/interfaces/interface_handler_impl.hpp:86: warning: Member comm_interfaces_field(PatchScheduler &sched, PatchComputeField< T > &pcomp_field, std::vector< InterfaceComm< vectype > > &interface_comm_list, std::unordered_map< u64, std::vector< std::tuple< u64, std::unique_ptr< PatchDataField< T > > > > > &interface_field_map, bool periodic) (function) of namespace impl is not documented.
+ src/shamrock/include/shamrock/legacy/patch/interfaces/interface_handler_impl.hpp:91: warning: Member comm_interfaces_field(PatchScheduler &sched, PatchComputeField< T > &pcomp_field, std::vector< InterfaceComm< vectype > > &interface_comm_list, std::unordered_map< u64, std::vector< std::tuple< u64, std::unique_ptr< PatchDataField< T > > > > > &interface_field_map, bool periodic) (function) of namespace impl is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:100: warning: Member PatchScheduler(const std::shared_ptr< shamrock::patch::PatchDataLayerLayout > &pdl_ptr, u64 crit_split, u64 crit_merge) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:105: warning: Member dump_status() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:107: warning: Member dump_status() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:107: warning: Member update_local_load_value(std::function< u64(shamrock::patch::Patch)> load_function) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:109: warning: Member update_local_load_value(std::function< u64(shamrock::patch::Patch)> load_function) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:116: warning: Member get_box_tranform() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:118: warning: Member get_box_tranform() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:119: warning: Member get_box_volume() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:121: warning: Member get_box_volume() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:121: warning: Member should_resize_box(bool node_in) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:123: warning: Member should_resize_box(bool node_in) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:154: warning: Member make_patch_base_grid(std::array< u32, dim > patch_count) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:156: warning: Member make_patch_base_grid(std::array< u32, dim > patch_count) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:168: warning: Member format_patch_coord(shamrock::patch::Patch p) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:170: warning: Member check_patchdata_locality_corectness() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:170: warning: Member format_patch_coord(shamrock::patch::Patch p) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:172: warning: Member check_patchdata_locality_corectness() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:173: warning: Member dump_local_patches(std::string filename) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:175: warning: Member dump_local_patches(std::string filename) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:175: warning: Member gather_data(u32 rank) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:177: warning: Member gather_data(u32 rank) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:180: warning: PatchScheduler::add_root_patch has @param documentation sections but no arguments
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:182: warning: PatchScheduler::add_root_patch has @param documentation sections but no arguments
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:200: warning: Member sync_build_LB(bool global_patch_sync, bool balance_load) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:202: warning: Member sync_build_LB(bool global_patch_sync, bool balance_load) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:203: warning: Member get_patch_transform() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:205: warning: Member get_patch_transform() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:240: warning: Member for_each_patch(Function &&fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:242: warning: Member for_each_patch(Function &&fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:253: warning: Member for_each_global_patch(std::function< void(const shamrock::patch::Patch)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:255: warning: Member for_each_global_patch(std::function< void(const shamrock::patch::Patch)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:261: warning: Member for_each_local_patch(std::function< void(const shamrock::patch::Patch)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:263: warning: Member for_each_local_patch(std::function< void(const shamrock::patch::Patch)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:269: warning: Member for_each_local_patchdata(std::function< void(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:271: warning: Member for_each_local_patchdata(std::function< void(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:278: warning: Member for_each_local_patch_nonempty(std::function< void(const shamrock::patch::Patch &)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:280: warning: Member for_each_local_patch_nonempty(std::function< void(const shamrock::patch::Patch &)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:290: warning: Member get_patch_rank_owner(u64 patch_id) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:292: warning: Member get_patch_rank_owner(u64 patch_id) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:296: warning: Member for_each_patchdata_nonempty(std::function< void(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:298: warning: Member for_each_patchdata_nonempty(std::function< void(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:309: warning: Member map_owned_patchdata(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:311: warning: Member map_owned_patchdata(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:322: warning: Member distrib_data_local_to_all_simple(shambase::DistributedData< T > &src) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:324: warning: Member distrib_data_local_to_all_simple(shambase::DistributedData< T > &src) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:335: warning: Member distrib_data_local_to_all_load_store(shambase::DistributedData< T > &src) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:337: warning: Member distrib_data_local_to_all_load_store(shambase::DistributedData< T > &src) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:346: warning: Member map_owned_patchdata_fetch_simple(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:348: warning: Member map_owned_patchdata_fetch_simple(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:359: warning: Member map_owned_patchdata_fetch_load_store(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:361: warning: Member map_owned_patchdata_fetch_load_store(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:372: warning: Member map_owned_to_patch_field_simple(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:374: warning: Member map_owned_to_patch_field_simple(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:378: warning: Member map_owned_to_patch_field_load_store(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:380: warning: Member map_owned_to_patch_field_load_store(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:383: warning: Member get_rank_count() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:385: warning: Member get_rank_count() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:394: warning: Member get_total_obj_count() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:396: warning: Member get_total_obj_count() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:401: warning: Member rankgather_field(u32 field_idx) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:403: warning: Member rankgather_field(u32 field_idx) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:459: warning: Member compute_patch_field(Pfield &field, MPI_Datatype &dtype, Function &&lambda) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:461: warning: Member compute_patch_field(Pfield &field, MPI_Datatype &dtype, Function &&lambda) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:477: warning: Member get_node_set_edge_patchdata_layer_refs() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:479: warning: Member get_node_set_edge_patchdata_layer_refs() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:498: warning: Member get_sim_box() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:500: warning: Member get_sim_box() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:500: warning: Member serialize_patch_metadata() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:502: warning: Member serialize_patch_metadata() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:80: warning: Member pdl() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:80: warning: Member pdl_old() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:82: warning: Member get_layout_ptr() const (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:84: warning: Member get_layout_ptr_old() const (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:94: warning: Member init_mpi_required_types() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:96: warning: Member free_mpi_required_types() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:96: warning: Member init_mpi_required_types() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:98: warning: Member PatchScheduler(const std::shared_ptr< shamrock::patch::PatchDataLayerLayout > &pdl_ptr, u64 crit_split, u64 crit_merge) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:98: warning: Member free_mpi_required_types() (function) of class PatchScheduler is not documented.