Skip to content

Conversation

@tdavidcl
Copy link
Member

@tdavidcl tdavidcl commented Apr 1, 2025

No description provided.

@tdavidcl tdavidcl changed the title [Env][Nix] fix nix again ... (missing CUDA backend)) [Env][Nix] fix nix again ... (missing CUDA backend) Apr 2, 2025
@tdavidcl tdavidcl marked this pull request as ready for review April 2, 2025 07:25
@github-actions
Copy link

github-actions bot commented Apr 2, 2025

Workflow report

workflow report corresponding to commit 4a08bf5
Commiter email is timothee.davidcleris@proton.me

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
isort....................................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 19
New warnings : 20
Warnings count : 5694 → 5695 (0.0%)

Detailed changes :
- src/shamsys/src/NodeInstance.cpp:233: warning: Member start_mpi(MPIInitInfo mpi_info) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:233: warning: Member start_mpi(MPIInitInfo mpi_info) (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:235: warning: Member start_mpi(MPIInitInfo mpi_info) (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:235: warning: Member start_mpi(MPIInitInfo mpi_info) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:283: warning: Member init_sycl_mpi(std::string search_key, MPIInitInfo mpi_info) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:283: warning: Member init_sycl_mpi(std::string search_key, MPIInitInfo mpi_info) (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:285: warning: Member init_strategy (variable) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:290: warning: Member init_sycl_mpi(std::string search_key, MPIInitInfo mpi_info) (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:290: warning: Member init_sycl_mpi(std::string search_key, MPIInitInfo mpi_info) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:345: warning: Member get_compute_scheduler() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:345: warning: Member get_compute_scheduler() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:347: warning: Member get_alt_scheduler() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:347: warning: Member get_alt_scheduler() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:349: warning: Member get_compute_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:349: warning: Member get_compute_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:353: warning: Member get_alt_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:353: warning: Member get_alt_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:355: warning: Member print_device_info(const sycl::device &Device) (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:356: warning: Member get_compute_scheduler() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:356: warning: Member get_compute_scheduler() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:358: warning: Member get_alt_scheduler() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:358: warning: Member get_alt_scheduler() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:360: warning: Member get_compute_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:360: warning: Member get_compute_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:362: warning: Member print_device_list() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:362: warning: Member print_device_list() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:364: warning: Member get_alt_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:364: warning: Member get_alt_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:366: warning: Member print_device_info(const sycl::device &Device) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:368: warning: Member print_mpi_capabilities() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:368: warning: Member print_mpi_capabilities() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:370: warning: Member check_dgpu_available() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:370: warning: Member check_dgpu_available() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:373: warning: Member print_device_list() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:373: warning: Member print_device_list() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:379: warning: Member print_mpi_capabilities() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:379: warning: Member print_mpi_capabilities() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:381: warning: Member check_dgpu_available() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:381: warning: Member check_dgpu_available() (function) of namespace shamsys::instance is not documented.

@tdavidcl tdavidcl merged commit f897239 into Shamrock-code:main Apr 2, 2025
31 checks passed
@tdavidcl tdavidcl deleted the fix/nixagain branch April 2, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant