Skip to content

Conversation

@tdavidcl
Copy link
Member

No description provided.

@github-actions
Copy link

Workflow report

workflow report corresponding to commit 5eebfa4
Commiter email is timothee.davidcleris@proton.me
Github page artifact URL Github page articact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
isort....................................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 10
New warnings : 30
Warnings count : 5835 → 5855 (0.3%)

Detailed changes :
- src/shamrock/include/shamrock/solvergraph/Field.hpp:25: warning: Compound shamrock::solvergraph::Field is not documented.
+ src/shamrock/include/shamrock/solvergraph/Field.hpp:26: warning: Compound shamrock::solvergraph::Field is not documented.
- src/shamrock/include/shamrock/solvergraph/Field.hpp:32: warning: Member Field(u32 nvar, std::string name, std::string texsymbol) (function) of class shamrock::solvergraph::Field is not documented.
+ src/shamrock/include/shamrock/solvergraph/Field.hpp:35: warning: Member Field(u32 nvar, std::string name, std::string texsymbol) (function) of class shamrock::solvergraph::Field is not documented.
- src/shamrock/include/shamrock/solvergraph/Field.hpp:36: warning: Member ensure_sizes(const shambase::DistributedData< u32 > &sizes) (function) of class shamrock::solvergraph::Field is not documented.
+ src/shamrock/include/shamrock/solvergraph/Field.hpp:38: warning: Member sync_refs() (function) of class shamrock::solvergraph::Field is not documented.
+ src/shamrock/include/shamrock/solvergraph/Field.hpp:47: warning: Member ensure_sizes(const shambase::DistributedData< u32 > &sizes) (function) of class shamrock::solvergraph::Field is not documented.
- src/shamrock/include/shamrock/solvergraph/Field.hpp:69: warning: Member extract() (function) of class shamrock::solvergraph::Field is not documented.
- src/shamrock/include/shamrock/solvergraph/Field.hpp:71: warning: Member internal_ref() (function) of class shamrock::solvergraph::Field is not documented.
+ src/shamrock/include/shamrock/solvergraph/Field.hpp:77: warning: Member extract() (function) of class shamrock::solvergraph::Field is not documented.
+ src/shamrock/include/shamrock/solvergraph/Field.hpp:82: warning: Member get_buf(u64 id_patch) (function) of class shamrock::solvergraph::Field is not documented.
+ src/shamrock/include/shamrock/solvergraph/Field.hpp:86: warning: Member get_field(u64 id_patch) (function) of class shamrock::solvergraph::Field is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldRefs.hpp:28: warning: Compound shamrock::solvergraph::FieldRefs is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldRefs.hpp:33: warning: Member field_refs (variable) of class shamrock::solvergraph::FieldRefs is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldRefs.hpp:33: warning: Member field_refs (variable) of class shamrock::solvergraph::FieldRefs is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldRefs.hpp:35: warning: Member sync_spans() (function) of class shamrock::solvergraph::FieldRefs is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldRefs.hpp:35: warning: Member sync_spans() (function) of class shamrock::solvergraph::FieldRefs is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldRefs.hpp:42: warning: Member check_sizes(const shambase::DistributedData< u32 > &sizes) const (function) of class shamrock::solvergraph::FieldRefs is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldRefs.hpp:42: warning: Member check_sizes(const shambase::DistributedData< u32 > &sizes) const (function) of class shamrock::solvergraph::FieldRefs is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldRefs.hpp:57: warning: Member set_ref_sync_spans(const shambase::DistributedData< std::reference_wrapper< PatchDataField< T > > > &field_refs) (function) of class shamrock::solvergraph::FieldRefs is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldRefs.hpp:57: warning: Member set_ref_sync_spans(const shambase::DistributedData< std::reference_wrapper< PatchDataField< T > > > &field_refs) (function) of class shamrock::solvergraph::FieldRefs is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldRefs.hpp:64: warning: Member get_field(u64 id_patch) const (function) of class shamrock::solvergraph::FieldRefs is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldRefs.hpp:64: warning: Member get_field(u64 id_patch) const (function) of class shamrock::solvergraph::FieldRefs is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldSpan.hpp:28: warning: Member IDataEdgeNamed(std::string name, std::string texsymbol) (function) of class shamrock::solvergraph::FieldSpan is not documented.
- src/shamrock/include/shamrock/solvergraph/FieldSpan.hpp:29: warning: Member spans (variable) of class shamrock::solvergraph::FieldSpan is not documented.
- src/shamrock/include/shamrock/solvergraph/FieldSpan.hpp:29: warning: Member spans (variable) of class shamrock::solvergraph::FieldSpan is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldSpan.hpp:30: warning: Member spans (variable) of class shamrock::solvergraph::FieldSpan is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldSpan.hpp:30: warning: Member spans (variable) of class shamrock::solvergraph::FieldSpan is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldSpan.hpp:30: warning: Member spans (variable) of class shamrock::solvergraph::FieldSpan is not documented.
- src/shamrock/include/shamrock/solvergraph/FieldSpan.hpp:31: warning: Member check_sizes(const shambase::DistributedData< u32 > &sizes) const (function) of class shamrock::solvergraph::FieldSpan is not documented.
- src/shamrock/include/shamrock/solvergraph/FieldSpan.hpp:31: warning: Member check_sizes(const shambase::DistributedData< u32 > &sizes) const (function) of class shamrock::solvergraph::FieldSpan is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldSpan.hpp:32: warning: Member check_sizes(const shambase::DistributedData< u32 > &sizes) const (function) of class shamrock::solvergraph::FieldSpan is not documented.
- src/shamrock/include/shamrock/solvergraph/FieldSpan.hpp:46: warning: Member ensure_sizes(const shambase::DistributedData< u32 > &sizes) (function) of class shamrock::solvergraph::FieldSpan is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldSpan.hpp:47: warning: Member ensure_sizes(const shambase::DistributedData< u32 > &sizes) (function) of class shamrock::solvergraph::FieldSpan is not documented.
+ src/shamrock/include/shamrock/solvergraph/FieldSpan.hpp:47: warning: Member ensure_sizes(const shambase::DistributedData< u32 > &sizes) (function) of class shamrock::solvergraph::FieldSpan is not documented.
+ src/shamrock/include/shamrock/solvergraph/IDataEdge.hpp:29: warning: Member get_label() const (function) of class shamrock::solvergraph::IDataEdge is not documented.
+ src/shamrock/include/shamrock/solvergraph/IDataEdge.hpp:30: warning: Member get_tex_symbol() const (function) of class shamrock::solvergraph::IDataEdge is not documented.
+ src/shamrock/include/shamrock/solvergraph/IDataEdgeNamed.hpp:28: warning: Member IDataEdgeNamed(std::string name, std::string texsymbol) (function) of class shamrock::solvergraph::IDataEdgeNamed is not documented.
+ src/shamrock/include/shamrock/solvergraph/IDataEdgeNamed.hpp:31: warning: Member _impl_get_dot_label() const (function) of class shamrock::solvergraph::IDataEdgeNamed is not documented.
+ src/shamrock/include/shamrock/solvergraph/IDataEdgeNamed.hpp:32: warning: Member _impl_get_tex_symbol() const (function) of class shamrock::solvergraph::IDataEdgeNamed is not documented.

@tdavidcl tdavidcl merged commit e1689ae into Shamrock-code:main May 12, 2025
34 checks passed
@tdavidcl tdavidcl deleted the feat/update-solvegraph branch May 12, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant