Description
IGNORED_DIRS in tests/spfx-template-test/src/tests/templates.test.ts includes teams, which excludes the teams/ directory from template scaffolding comparison and sync. However, teams/ is not listed in the .gitignore files of the templates or examples that generate it (e.g. webpart-react).
The teams/ directory should be added to the .gitignore of each template/example that generates it, so that the traversal skips it naturally via the gitignore matcher rather than relying on the hardcoded IGNORED_DIRS list. This would make the exclusion self-documenting and consistent with how other generated directories (e.g. dist, lib) are handled.
Alternatives considered
Removing teams from IGNORED_DIRS and including it in comparison/sync — but this would require the teams/ PNG assets to be reproducible across scaffold runs, which should be verified first.
Related
Noted as a follow-up in #231.
Description
IGNORED_DIRSintests/spfx-template-test/src/tests/templates.test.tsincludesteams, which excludes theteams/directory from template scaffolding comparison and sync. However,teams/is not listed in the.gitignorefiles of the templates or examples that generate it (e.g.webpart-react).The
teams/directory should be added to the.gitignoreof each template/example that generates it, so that the traversal skips it naturally via the gitignore matcher rather than relying on the hardcodedIGNORED_DIRSlist. This would make the exclusion self-documenting and consistent with how other generated directories (e.g.dist,lib) are handled.Alternatives considered
Removing
teamsfromIGNORED_DIRSand including it in comparison/sync — but this would require theteams/PNG assets to be reproducible across scaffold runs, which should be verified first.Related
Noted as a follow-up in #231.