Skip to content

Include Node 24 in the test matrix.#172

Merged
iclanton merged 3 commits into
SharePoint:mainfrom
iclanton:node-24
Mar 24, 2026
Merged

Include Node 24 in the test matrix.#172
iclanton merged 3 commits into
SharePoint:mainfrom
iclanton:node-24

Conversation

@iclanton
Copy link
Copy Markdown
Contributor

Description

Includes Node 24 in the test matrix.

How was this tested?

Added new test pipelines.

Type of change

  • Bug fix
  • New feature / enhancement
  • Template change
  • Documentation / CI / governance

Copilot AI review requested due to automatic review settings March 23, 2026 23:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI and repo metadata to add Node.js 24 coverage, aligning tooling/docs with an expanded supported Node version range.

Changes:

  • Expand Rush-supported Node range to include Node 24 and update pipeline defaults accordingly.
  • Update GitHub Actions CI to run a Node 22 + Node 24 matrix (and bump actions/setup-node to v6).
  • Update package engines/READMEs and add a Rush change file.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
tools/spfx-cli-build-rig/package.json Updates engines.node to include a Node 24 range.
tests/spfx-template-test/package.json Updates engines.node to include a Node 24 range for template tests.
rush.json Expands nodeSupportedVersionRange to include Node 24.
common/config/azure-pipelines/templates/install-node.yaml Changes default Node version installed in AzDo template.
common/changes/@microsoft/spfx-cli/node-24_2026-03-23-23-50.json Adds required Rush change file for the package-affecting updates.
apps/spfx-cli/README.md Updates documented Node requirements.
apps/spfx-cli/package.json Updates engines.node Node 24 minimum.
api/spfx-template-api/README.md Updates documented Node requirements.
.github/workflows/ci.yml Adds Node 22/24 matrix and switches to actions/setup-node@v6.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rush.json
Comment thread common/config/azure-pipelines/templates/install-node.yaml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml
Comment thread apps/spfx-cli/package.json Outdated
Comment thread tools/spfx-cli-build-rig/package.json Outdated
Comment thread tests/spfx-template-test/package.json Outdated
Comment thread apps/spfx-cli/README.md Outdated
Comment thread api/spfx-template-api/README.md Outdated
@iclanton iclanton enabled auto-merge (squash) March 24, 2026 15:39
Comment thread common/pnpm-patches/@microsoft__spfx-heft-plugins@1.22.2.patch
@iclanton iclanton merged commit b1a9917 into SharePoint:main Mar 24, 2026
4 checks passed
@iclanton iclanton deleted the node-24 branch April 2, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants