docs(polymarket-resolution): snake_case to match wire convention#226
Merged
Conversation
The customer-visible field name on /odds is polymarket_resolution (snake_case), matching odds_american / event_id / selection_type / volume_24h / exchange_token_id etc. Initial doc landed with camelCase, which is what api-adapters emits internally on the publish path but isn't what customers see on the SSE/REST wire.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field is
polymarket_resolutionon the customer wire (matches odds_american, event_id, etc), notpolymarketResolution. Docs landed with camelCase by mistake — that's the internal api-adapters publish format, not what customers see.