Skip to content

fix(build): ensure Homebrew path includes on Apple Silicon for cmake#67

Merged
solderzzc merged 1 commit intomainfrom
fix/build-sh-homebrew-path
Apr 20, 2026
Merged

fix(build): ensure Homebrew path includes on Apple Silicon for cmake#67
solderzzc merged 1 commit intomainfrom
fix/build-sh-homebrew-path

Conversation

@solderzzc
Copy link
Copy Markdown
Member

Fixes #63.

The build.sh script natively struggled to resolve cmake and brew via Homebrew on Apple Silicon Macs when triggered via specific shells because /opt/homebrew/bin was not injected into the $PATH automatically. This applies a robust fix directly into the shell context.

(Note: The other root cause of Issue #63 regarding the GLM 5.1 code leakage throwing inconsistent compilation errors has already been resolved natively down the dependency tree by reverting the branch and re-aligning the clean SwiftLM submodules in main.)

Copilot AI review requested due to automatic review settings April 20, 2026 02:51
@solderzzc solderzzc merged commit dc877e9 into main Apr 20, 2026
2 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the root build script to reliably locate Homebrew-installed tooling (notably cmake/brew) on Apple Silicon by ensuring common Homebrew install locations are present in the script’s PATH.

Changes:

  • Prepend /opt/homebrew/bin and /usr/local/bin to PATH at the start of build.sh.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread build.sh
Comment on lines +4 to +5
export PATH="/opt/homebrew/bin:/usr/local/bin:$PATH"

Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prepending /opt/homebrew/bin and /usr/local/bin to PATH globally can unintentionally change which swift/cmake/etc. binaries are used if the user already has custom toolchains in their existing $PATH. Consider only adding the Homebrew paths when brew/cmake aren’t found, and/or only adding directories that exist and aren’t already present in PATH (optionally include .../sbin).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

./build.sh is currently broken

2 participants