Project configuration cleanup#3
Merged
arakis merged 2 commits intoSharpKit:masterfrom Jul 16, 2014
Merged
Conversation
Member
|
Commit 14d332e seems to be fine. Commit bf81251 is mostly ok, too, but maye we shuld discuss about it first. You're right, the chars <, > and so on have to be written down in encoded form. But fact is, that this was "never" a problem for visual studio or monodevelop (as i remind). Both IDEs shows the chars like expected. Only a warning will be shown. On the other side, avoiding the html encoding makes the comments more readable / modifyable in the source code. The specific warning ("Error code") can be supressed. Your other comment fixes seems to be ok (removed unneeded spaces, other attribute names and so on). |
Member
|
I just checked the comments behavior. They need to be encoded. So, the merge is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the result if #2
All project files in Defs now only have one configuration: Debug/AnyCPU
Fixed or ignored various warnings mostly related to malformed comments.