Merged
Conversation
Support newer RTAComplete.txt format
Bump minimum Python version to 3.9
Switch from pkg_resources to importlib.metadata for version handling
Also bump dependency versions in setup.py to reflect new Python
The install command works differently if it detects that umbra is inside a conda env, but I evidently never handled that correctly in circleci's use of the install command
Skip blank config paths during install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
illumina.util.load_rta_completenow handles the syntax used by NextSeq and MiSeq i100 Plus software for RTAComplete.txt (#132)Changed
Fixed