-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix make dist and browserify issue require #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @Liryna ! The breaks in the require statements are used to trick browserify into not including those files. If |
|
Hi @SheetJSDev , It is not really browserify in my case, it is meteor that do his magic trick to detect which JS are used by scanning the require to send to the client side. With the break, it seems like meteor is unable to see it and the jszip is for example not sent and therefore missing at runtime.😢 |
|
@Liryna the relevant changes were applied to un-break the require statements. Please check if it works. Keep the PR open though, since you also made some changes to the makefile I also want to revisit the build infrastructure |
|
Hi @SheetJSDev , Thank you for the changes ! Yes it worked for me on meteor 👍 |
|
We also folded the ODS logic into xlsx.js and reworked the cpexcel build to omit the unnecessary require, so I think we settled the require issues. GNU sed doesn't accept a space between the |
- decode sheet name for XLSX and XLML (fixes #203 h/t @rocketmonkeys) - XFExt (fixes #298 h/t @aetna-softwares @aimcom @baharudinafif) - handle truly empty `<is>` elements (fixes #506 h/t @asksahil) - pin version numbers for dependencies (fixes #469 h/t @nhtera) - sed usage fix (see #572 h/t @Liryna) - fix hex2RGB substr indices (fixes #294 h/t @kamorahul) - removed stale typescript files (see #442) - reworked shift formula regex (fixed #551 h/t @SheetJSDev) - README note on webpack codepage suppression (fixes #438 h/t @rusty1s) - README note on WTF (fixes #487 h/t @livesoftware)
- decode sheet name for XLSX and XLML (fixes SheetJS#203 h/t @rocketmonkeys) - XFExt (fixes SheetJS#298 h/t @aetna-softwares @aimcom @baharudinafif) - handle truly empty `<is>` elements (fixes SheetJS#506 h/t @asksahil) - pin version numbers for dependencies (fixes SheetJS#469 h/t @nhtera) - sed usage fix (see SheetJS#572 h/t @Liryna) - fix hex2RGB substr indices (fixes SheetJS#294 h/t @kamorahul) - removed stale typescript files (see SheetJS#442) - reworked shift formula regex (fixed SheetJS#551 h/t @SheetJSDev) - README note on webpack codepage suppression (fixes SheetJS#438 h/t @rusty1s) - README note on WTF (fixes SheetJS#487 h/t @livesoftware)
No description provided.