-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Style/theme implementation #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@elad good start! I added a few test files. In particular, take a look at https://github.com/SheetJS/test_files/raw/master/cell_style_simple.xlsx -- this has a few column styles as well as row styles, block styles and individual cell styles. Do the colors roughly line up with the sheet? After doing all of that, please squash to one commit :) |
|
I just realized that I only took care of |
|
I think I managed to squash it... Had to merge master though otherwise it wouldn't let me push. |
|
@elad Your log still shows 8 commits. You should only end up with one commit. You might need to do a |
|
And now? |
|
Now we are down to one :) Clean up the git message (fortunately this is just |
|
Done. :) |
Huge thanks to @SheetJS for guidance on how to do all of this! Experimental, guarded by the cellStyles option (default: false)
|
@elad thank you very very much :) |
|
You're welcome! Thank you for working on such a fantastic project! :) |
- parse_XFExtGradient stubbed (fixes SheetJS#62, h/t @oakuraape) - default to UTF16LE (fixes SheetJS#64, h/t @ajuhos) - ensure that date1904 is propagated to SSF (fixes SheetJS#66, h/t @Martin-Pitt) - pin CFB version in anticipation of future changes
Initial implementation of style/theme parsing, following your input.
Experimental and guarded by the cellStyles option (default: false)
Addresses issue #36