refactor(pqvm): rename shell-evm crate#52
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the execution adapter crate from shell-evm (crates/evm) to shell-pqvm (crates/pqvm) and updates the Rust codebase, docs, CLI/config, and tests/benches to use PQVM terminology while preserving legacy Ethereum tooling compatibility surfaces (eth_*, evm debug namespace, deprecated parallel-evm* aliases).
Changes:
- Rename the execution crate to
shell-pqvmand update workspace membership/dependencies/imports throughout the node, RPC, mempool, tools, and docs. - Preserve the
evmRPC namespace for Hardhat/Foundry compatibility by renaming the trait/server types toLegacyEvmApi*. - Introduce/rename “parallel PQVM” configuration and CLI flags with deprecated
parallel-evmaliases.
Reviewed changes
Copilot reviewed 45 out of 54 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| UPGRADE.md | Renames the Prometheus gas-used metric to shell_pqvm_gas_used_total. |
| tools/tx-generator/src/bin/shell-aa-injector.rs | Updates tool import to shell_pqvm. |
| tools/tx-generator/Cargo.toml | Switches dependency from shell-evm to shell-pqvm. |
| tools/tx-generator/Cargo.lock | Updates locked deps/versions to reflect the crate rename. |
| README.md | Updates terminology and crate diagram to shell-pqvm / revm adapter boundary. |
| docs/SYSTEM_CONTRACTS.md | Updates reference to SYSTEM_CALL_BASE_GAS crate name. |
| docs/node-cli.md | Documents --parallel-pqvm* flags and deprecated --parallel-evm* aliases. |
| docs/ACCOUNT_ABSTRACTION_GUIDE.md | Updates file path references from crates/evm to crates/pqvm. |
| crates/rpc/src/server.rs | Uses LegacyEvmApiServer in the evm namespace module merge. |
| crates/rpc/src/handler/shell_api.rs | Switches governance calldata/constants to shell_pqvm. |
| crates/rpc/src/handler/net.rs | Switches debug trace structs to shell_pqvm. |
| crates/rpc/src/handler/mod.rs | Replaces ShellEvm with ShellPqvm and updates tests/utilities accordingly. |
| crates/rpc/src/handler/evm.rs | Renames dev RPC impl to LegacyEvmApiServer and updates error text. |
| crates/rpc/src/filter.rs | Switches bloom filter implementation source to shell_pqvm. |
| crates/rpc/src/api.rs | Renames EvmApi trait to LegacyEvmApi while keeping namespace evm. |
| crates/rpc/Cargo.toml | Swaps dependency from shell-evm to shell-pqvm. |
| crates/pqvm/tests/key_rotation.rs | Updates tests to import from shell_pqvm. |
| crates/pqvm/tests/integration.rs | Updates integration tests to use ShellPqvm and renamed commit helper. |
| crates/pqvm/tests/common/mod.rs | Updates shared test utilities to ShellPqvm / commit_pqvm_state. |
| crates/pqvm/tests/aa_integration.rs | Updates AA integration tests to import from shell_pqvm. |
| crates/pqvm/src/tx_validation.rs | PQVM transaction validation pipeline (ported/renamed). |
| crates/pqvm/src/tracer.rs | Trace types used by RPC debug/trace endpoints with updated wording. |
| crates/pqvm/src/state_db.rs | State DB bridge for revm with PQ address hinting support. |
| crates/pqvm/src/rwset.rs | Updates parallel scheduler wording to PQVM. |
| crates/pqvm/src/precompiles.rs | PQ precompile provider (0x0001–0x0006) for revm integration. |
| crates/pqvm/src/pqvm_opcodes.rs | Adds native PQVM opcode handlers and installer. |
| crates/pqvm/src/parallel.rs | Renames parallel config/types from EVM to PQVM. |
| crates/pqvm/src/lib.rs | Updates public exports to PQVM names (ShellPqvm, commit_pqvm_state, etc.). |
| crates/pqvm/src/executor.rs | Renames executor wrapper and commit function; updates errors/messages. |
| crates/pqvm/src/bloom.rs | Adds/ports logs bloom implementation under shell_pqvm. |
| crates/pqvm/src/aa_validation.rs | Adds/ports AA validation logic under shell_pqvm. |
| crates/pqvm/Cargo.toml | Renames crate package from shell-evm to shell-pqvm. |
| crates/pqvm/benches/pqvm_bench.rs | Updates benchmark crate/type names and benchmark IDs to PQVM. |
| crates/pqvm/benches/parallel_poc.rs | Updates bench imports/config names to ParallelPqvmConfig. |
| crates/pqvm/benches/parallel_bench.rs | Updates bench naming and imports to PQVM terminology. |
| crates/node/src/node/mod.rs | Switches node execution/commit/system effects imports to shell_pqvm. |
| crates/node/src/node/block_producer.rs | Uses ShellPqvm and commit_pqvm_state; updates bloom union source. |
| crates/node/src/node/block_importer.rs | Uses ShellPqvm and commit_pqvm_state during import/re-exec. |
| crates/node/src/error.rs | Renames node error variant from EVM to PQVM executor error. |
| crates/node/src/config.rs | Renames node config field/type export to ParallelPqvmConfig. |
| crates/node/Cargo.toml | Swaps dependency from shell-evm to shell-pqvm. |
| crates/mempool/src/pool.rs | Switches validation/intrinsic gas imports to shell_pqvm. |
| crates/mempool/Cargo.toml | Swaps dependency from shell-evm to shell-pqvm. |
| crates/cli/src/main.rs | Adds preferred --parallel-pqvm* flags with deprecated --parallel-evm* aliases. |
| crates/cli/src/config.rs | Renames [parallel_evm] section to [parallel_pqvm] with serde alias for backwards compat. |
| crates/cli/src/commands/run.rs | Wires parallel PQVM flags into node config and updates related tests. |
| crates/cli/Cargo.toml | Swaps dependency from shell-evm to shell-pqvm. |
| config/node.example.toml | Documents [parallel_pqvm] section and deprecated aliases. |
| CHANGELOG.md | Updates changelog terminology/paths and metric names to PQVM. |
| Cargo.toml | Replaces workspace member crates/evm with crates/pqvm. |
| Cargo.lock | Removes shell-evm package entry and adds shell-pqvm. |
| blog/why-native-account-abstraction.md | Updates narrative terminology from EVM execution to PQVM execution. |
| AGENTS.md | Updates crate list entry from evm to pqvm. |
Comments suppressed due to low confidence (1)
crates/pqvm/src/tracer.rs:9
- Grammar: “in an PQVM/revm execution trace” should be “in a PQVM/revm execution trace”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/evm/shell-evmtocrates/pqvm/shell-pqvm.parallel_pqvmCLI/config names while keeping deprecatedparallel_evmcompatibility aliases.eth_*, the legacy debugevmnamespace, and revm adapter terminology.Validation
cargo check -p shell-pqvm --quietcargo check --workspace --quietcargo fmt --all -- --checkcargo clippy --workspace -- -D warningscargo test --workspacecargo fmt --all -- --check && cargo check -p shell-rpc --quiet./harness/tools/impact.py shell-chainshell-sdk npm test,shell-site npm run lint && npm test && npm run build,shell-explorer npm run lint && npm test && npm run build,shell-dex npm test && npm run build,shella-chrome-wallet npm test.Impact checklist notes
Impact-Deferred: shell-chain:
make e2erequires a local Docker daemon; the command was attempted and blocked because Docker was not running.Impact-Deferred: shell-dex: live trade-flow smoke against a new chain build was not run because no local devnet/Docker environment was available.
Impact-Deferred: shell-explorer: live devnet smoke, tx decode smoke, and RPC render smoke were not run because no local devnet/Docker environment was available.
Impact-Deferred: shella-chrome-wallet: manual sign-and-send against a new chain build was not run because no local devnet/Docker environment was available; automated wallet tests pass.