Add beatmap tests + __repr__() method for objects#7
Merged
Sheppsu merged 22 commits intoSheppsu:mainfrom Aug 4, 2022
Merged
Conversation
� Conflicts: � osu/objects/score.py � requirements.txt
Sheppsu
requested changes
Aug 3, 2022
Contributor
Author
|
something broke again in tests, need to investigate |
Contributor
Author
|
apparently it's in new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(needs a review)
Gives each object in
osu/objectsa__repr__()method that utilizesprettify()function to display the class name of the object and some attributes specified as paramsas
User(username='nouvelle', id=6943941)Beatmap(version="Bonzphyxia's Extra", beatmapset=Beatmapset(artist='USAO', title='Night sky', creator='sukiNathan'))Adds auto tests for API methods based on pytest and the corresponding fixtures (only beatmap tests provided yet)
Running tests:
pytest_tests/constants.pypytest pytest_testsI'm not sure if having pytest in
requirements.txtwill make users obtain that package on osu.py installation (it shouldn't happen since pytest is only used for dev purpose)