Skip to content

Replace CLA with DCO, use pre-built cargo-audit#2

Merged
shiftcontrol-dan merged 2 commits intomainfrom
fix-audit-cache
Mar 15, 2026
Merged

Replace CLA with DCO, use pre-built cargo-audit#2
shiftcontrol-dan merged 2 commits intomainfrom
fix-audit-cache

Conversation

@shiftcontrol-dan
Copy link
Contributor

@shiftcontrol-dan shiftcontrol-dan commented Mar 15, 2026

Summary

  • Replace CLA with DCO — removed contributor-assistant (required tokens, branches, PAT, caused endless CI failures). Replaced with githubtools/dco-action which just checks for Signed-off-by: line in commits. Zero infrastructure, standard practice (Linux kernel, CNCF, Docker, Kubernetes).
  • Pre-built cargo-auditcargo install cargo-audit compiled 401 crates from source (~2 min per run). Now uses taiki-e/install-action for pre-built binary (~3 sec).
  • Deleted: CLA.md, .github/workflows/cla.yml, cla-signatures branch
  • Updated CONTRIBUTING.md with DCO sign-off instructions

Test plan

  • DCO check passes (commit has Signed-off-by line)
  • Audit job installs in seconds, not minutes
  • No CLA-related workflows running

🤖 Generated with Claude Code

cargo install cargo-audit compiled 401 crates from source on every CI
run (~2 minutes). Switch to taiki-e/install-action which downloads a
pre-built binary (~3 seconds).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@amazon-inspector-singapore
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-singapore
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

- Replace contributor-assistant CLA (required tokens, branches,
  external service) with DCO check (zero infrastructure, standard
  in Rust/CNCF ecosystem). Contributors add `Signed-off-by` via
  `git commit -s`.
- Remove CLA.md, cla.yml, cla-signatures branch
- Add dco.yml using githubtools/dco-action
- Update CONTRIBUTING.md with DCO sign-off instructions
- Use pre-built cargo-audit binary via taiki-e/install-action
  (was compiling 401 crates from source every CI run)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Dan Gericke <dan@shiftcontrol.io>
@shiftcontrol-dan shiftcontrol-dan changed the title Use pre-built cargo-audit binary Replace CLA with DCO, use pre-built cargo-audit Mar 15, 2026
@shiftcontrol-dan shiftcontrol-dan merged commit 3102c22 into main Mar 15, 2026
5 of 6 checks passed
@shiftcontrol-dan shiftcontrol-dan deleted the fix-audit-cache branch March 15, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant