More fixes for OSS data flow#1083
Merged
Merged
Conversation
itsacoderepo
approved these changes
Jan 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt to correctly connect edges to the method exit node yesterday was a bit too naive: we can't just connect any nodes that do not have outgoing edges, we need to connect all "incoming definitions" to the exit node, of course. There was furthermore a problem with application of semantics: for annotated methods, we still always assumed that the return value is tainted, independent of the contents of the semantics. Both issues are fixed with this PR. The remainder of the changes are cosmetic.