make queryInit explicitly return a Query to avoid casts#1099
Merged
Conversation
note: in order to reference `Query` from the macro i needed to pull it out to another common dependency - you probably want to move it somewhere else
ursachec
approved these changes
Jan 28, 2021
Contributor
Author
|
|
fabsx00
approved these changes
Jan 28, 2021
Contributor
Author
|
@ursachec i assumed you wanted to move the query class somewhere else, or did you want to keep it where it is? I don't mind either way |
Contributor
|
@mpollmeier ah, sorry, should have been more reponsive there. it looks ok as it is at the moment. we can move it later if necessary |
delete-merged-branch
Bot
deleted the
michael/querymacros-explicit-return-type
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: in order to reference
Queryfrom the macro i needed to pull itout to another common dependency - you probably want to move it
somewhere else