Skip to content

Add the offset and offsetEnd property to all AST nodes #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johannescoetzee merged 2 commits into from
Feb 21, 2025
Merged

Add the offset and offsetEnd property to all AST nodes #1810

johannescoetzee merged 2 commits into from
Feb 21, 2025

Conversation

@johannescoetzee
Copy link
Contributor

@johannescoetzee johannescoetzee commented Feb 20, 2025

This is the first step towards always using the code field to represent the lowering and the offset + fileContent fields for the literal source representation.

@johannescoetzee johannescoetzee requested a review from ml86 February 20, 2025 17:07
@johannescoetzee johannescoetzee merged commit 0c7f719 into master Feb 21, 2025
1 check passed
@johannescoetzee johannescoetzee deleted the johannes/all-ast-node-offset branch February 21, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ml86 ml86 ml86 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johannescoetzee @ml86