[RFC] support accumulator in cpgpass without API changes#1846
Closed
max-leuthaeuser wants to merge 3 commits intomasterfrom
Closed
[RFC] support accumulator in cpgpass without API changes#1846max-leuthaeuser wants to merge 3 commits intomasterfrom
max-leuthaeuser wants to merge 3 commits intomasterfrom
Conversation
Contributor
Author
|
I will create a new PR merging all the stuff we discussed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote ForkJoinParallelCpgPassWithAccumulator to use the stream.collect(Supplier, BiConsumer, BiConsumer) API instead of ThreadLocal + ConcurrentLinkedQueue.
- Supplier: creates a fresh BuilderWithAccumulator(newDiffGraphBuilder, newAccumulator())
- Accumulator BiConsumer: calls runOnPartWithAccumulator(bwa.builder, bwa.acc, part)
- Combiner BiConsumer: absorbs the right builder into the left AND merges accumulators via mergeAccumulators
Hence: no API changes to the original ForkJoinParallelCpgPass, no null/Null, still using the pretty stream.collect(Supplier, BiConsumer, BiConsumer) API.
Downside: some code duplication. That's unavoidable if you don't want to change the existing API.