Skip to content

Conversation

@ShimmerEngineering
Copy link
Owner

No description provided.

@ShimmerEngineering ShimmerEngineering requested review from RuMolloy and jyong15 and removed request for jyong15 May 31, 2021 15:56
Copy link
Contributor

@RuMolloy RuMolloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after manually stepping through with JC, JC has changes noted but unable to push due to Github services down (updates required to readme and build.gradle files)

Copy link
Contributor

@RuMolloy RuMolloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after manually stepping through with JC, JC has changes noted but unable to push due to Github services down (updates required to readme and build.gradle files)

# Conflicts:
#	ShimmerAndroidInstrumentDriver/ShimmerAndroidInstrumentDriver/build.gradle
Copy link
Contributor

@RuMolloy RuMolloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, happy with this

@RuMolloy RuMolloy self-requested a review June 2, 2021 09:22
@JongChern JongChern merged commit cd876b2 into master Jun 2, 2021
@JongChern JongChern deleted the JA-49_test branch June 2, 2021 09:24
@JongChern JongChern restored the JA-49_test branch June 3, 2021 05:13
@JongChern JongChern deleted the JA-49_test branch June 3, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants