JA-49 #28
Merged
JA-49 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject ShimmerAndroidInstrumentDriver for the time being
…ject ShimmerAndroidInstrumentDriver for the time being
ShimmerEngineering
requested review from
RuMolloy and
jyong15
and removed request for
jyong15
RuMolloy
suggested changes
Jun 2, 2021
Contributor
RuMolloy
left a comment
RuMolloy
left a comment
There was a problem hiding this comment.
Looks good after manually stepping through with JC, JC has changes noted but unable to push due to Github services down (updates required to readme and build.gradle files)
RuMolloy
suggested changes
Jun 2, 2021
Contributor
RuMolloy
left a comment
RuMolloy
left a comment
There was a problem hiding this comment.
Looks good after manually stepping through with JC, JC has changes noted but unable to push due to Github services down (updates required to readme and build.gradle files)
# Conflicts: # ShimmerAndroidInstrumentDriver/ShimmerAndroidInstrumentDriver/build.gradle
RuMolloy
approved these changes
Jun 2, 2021
Contributor
RuMolloy
left a comment
RuMolloy
left a comment
There was a problem hiding this comment.
Looks good, happy with this
RuMolloy
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.